Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): add Horizon delta for User Menu [ci visual] #4168

Merged
merged 3 commits into from Jan 25, 2023

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Closes #4091

@InnaAtanasova InnaAtanasova added this to the Sprint 104 milestone Jan 10, 2023
@InnaAtanasova InnaAtanasova requested a review from a team January 10, 2023 20:52
@InnaAtanasova InnaAtanasova self-assigned this Jan 10, 2023
@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 789b451
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/63d17dbe0f98130008b8361c
😎 Deploy Preview https://deploy-preview-4168--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think when there is a footer present, the last list item should not have bottom border radii when focused:

Screenshot 2023-01-11 at 10 17 46 AM

Copy link
Contributor

@platon-rov platon-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have such big spacing?

image

Looks like in wiki it's 8px always
image

Plus, rounding of focus outline seems redundant when there are paddings.

@InnaAtanasova
Copy link
Contributor Author

InnaAtanasova commented Jan 13, 2023

Why do we have such big spacing?

image

Looks like in wiki it's 8px always image

Plus, rounding of focus outline seems redundant when there are paddings.

For the rounded corners: fixed

As for the spacing, the Popover paddings are these:
Screenshot 2023-01-13 at 10 19 01 AM

@InnaAtanasova
Copy link
Contributor Author

I would think when there is a footer present, the last list item should not have bottom border radii when focused:

Screenshot 2023-01-11 at 10 17 46 AM

fixed

ul:last-child li:last-child::before,
ul li:last-child::before,
ul li:last-child a::before {
border-radius: 0 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably first-child too?
Screenshot 2023-01-24 at 4 01 24 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@InnaAtanasova InnaAtanasova modified the milestones: Sprint 104, Sprint 105 Jan 25, 2023
@InnaAtanasova InnaAtanasova merged commit f0d242c into main Jan 25, 2023
@InnaAtanasova InnaAtanasova deleted the fix/user-menu-horizon branch January 25, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Horizon Delta for User Menu
3 participants