Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(styles): update Table to use Toolbar Title [ci visual] #4174

Merged
merged 1 commit into from Jan 18, 2023

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Closes #4088

Description

Update the Toolbar used in tables to Title Toolbar and the

with the appropriate classes.

BREAKING CHANGE:

  • fd-toolbar--solid class is removed
  • the h4 element in the Toolbar has classes fd-title fd-title--h4 fd-toolbar__title

Before:

<div class="fd-toolbar fd-toolbar--solid fd-toolbar--title fd-toolbar-active">
    <h4>Default Table</h4>
    <span class="fd-toolbar__spacer fd-toolbar__spacer--auto"></span>
</div>

Now:

<div class="fd-toolbar fd-toolbar--title fd-toolbar-active">
    <h4 class="fd-title fd-title--h4 fd-toolbar__title">Default Table</h4>
    <span class="fd-toolbar__spacer fd-toolbar__spacer--auto"></span>
</div>```

@InnaAtanasova InnaAtanasova added the Bug Something isn't working label Jan 13, 2023
@InnaAtanasova InnaAtanasova added this to the Sprint 104 milestone Jan 13, 2023
@InnaAtanasova InnaAtanasova requested a review from a team January 13, 2023 18:23
@InnaAtanasova InnaAtanasova self-assigned this Jan 13, 2023
@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit de9caa9
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/63c1a18d15f8c60008d38bcb
😎 Deploy Preview https://deploy-preview-4174--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@InnaAtanasova InnaAtanasova merged commit 5b1bbf2 into main Jan 18, 2023
@InnaAtanasova InnaAtanasova deleted the fix/table-toolbar-examples branch January 18, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Table with Header/Title Toolbar example
2 participants