Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added js to publish #4237

Merged
merged 3 commits into from Feb 13, 2023
Merged

feat: added js to publish #4237

merged 3 commits into from Feb 13, 2023

Conversation

g-cheishvili
Copy link
Contributor

Description

This change adds JS module export and also it's typing to published packages. This is for using in cases when you might want to import sources in environment, where you do not have access to bundlers, for example when you are writing package for angular.

@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 83b4847
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/63e9ed79de17c000088305ae
😎 Deploy Preview https://deploy-preview-4237--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@N1XUS
Copy link
Contributor

N1XUS commented Feb 6, 2023

Cool! @g-cheishvili shouldn't final package.json be also updated for paths of import?

@N1XUS N1XUS force-pushed the feat/added_export_js_modules branch from 1748c4f to 83b4847 Compare February 13, 2023 07:57
@N1XUS N1XUS merged commit 56b71dc into main Feb 13, 2023
@N1XUS N1XUS deleted the feat/added_export_js_modules branch February 13, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants