Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): update Message Strip to latest Horizon design [ci visual] #4426

Merged
merged 1 commit into from Apr 5, 2023

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Apr 4, 2023

Related Issue

Closes #4383

Description

  • added custom icon
  • added custom colors (accent colors)
  • text with Link option
  • a11y improvements: aria-role is changed, added aria-live, aria-labelledby, etc.

BREAKING CHANGE:
Markup change: - the ability to add custom icon required change in the markup. The status icon is no longer added by the modifier class, but is wrapped in a container.

Before:

<div class="fd-message-strip fd-message-strip--information fd-message-strip--dismissible" role="alert">
  <p class="fd-message-strip__text">...</p>
</div>

After:

<div class="fd-message-strip fd-message-strip--information fd-message-strip--dismissible" role="note" aria-live="assertive" id="message-strip-2" aria-labelledby="message-strip-2">
  <div class="fd-message-strip__icon-container" aria-hidden="true">
    <span class="sap-icon sap-icon--message-information" focusable="false" role="presentation" aria-hidden="true"></span>
  </div>
  <p class="fd-message-strip__text">...</p>
</div>

New modifier classes:

  • fd-message-strip--link - for when the text has a link (The Link inside Message Strip has additional styling.)
  • fd-message-strip--accent-color-*, where * is a number from 1 to 10. - for custom color

A11y

  • replaced aria-role="alert" with role="note"
  • added aria-live="assertive", id and aria-labelledby

@InnaAtanasova InnaAtanasova added the Horizon 2023 Horizon Design Changes in 2023 label Apr 4, 2023
@InnaAtanasova InnaAtanasova added this to the Sprint 110 milestone Apr 4, 2023
@InnaAtanasova InnaAtanasova requested a review from a team April 4, 2023 23:08
@InnaAtanasova InnaAtanasova self-assigned this Apr 4, 2023
@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 9780d88
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/642dc4a2b31c74000832f21f
😎 Deploy Preview https://deploy-preview-4426--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@droshev droshev merged commit 17af442 into main Apr 5, 2023
13 checks passed
@droshev droshev deleted the fix/message-strip-updates branch April 5, 2023 19:14
@droshev droshev mentioned this pull request Apr 8, 2023
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Horizon 2023 Horizon Design Changes in 2023
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Component Design Update: Message Strip
2 participants