Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): update Checkbox to latest Horizon 2023 [ci visual] #4480

Merged
merged 1 commit into from Apr 26, 2023

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Closes #4372

@InnaAtanasova InnaAtanasova added the Horizon 2023 Horizon Design Changes in 2023 label Apr 25, 2023
@InnaAtanasova InnaAtanasova added this to the Sprint 111 milestone Apr 25, 2023
@InnaAtanasova InnaAtanasova requested a review from a team April 25, 2023 21:53
@InnaAtanasova InnaAtanasova self-assigned this Apr 25, 2023
@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 0d7dc43
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/64495f220f5a8300087b8fdc
😎 Deploy Preview https://deploy-preview-4480--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

--fdCheckbox_Focus_Outline_Offset: 0.25rem;
--fdCheckbox_Outline_Border_Radius: 0.8rem;
--fdCheckbox_Compact_Outline_Border_Radius: 0.5rem;

// Default
--fdCheckbox_Background_Color_Default: var(--sapField_Background);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the properties can be extracted to the shared variables file, for example, --fdCheckbox_Background_Color_Default: var(--sapField_Background); for horizon and horizon_hc are the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, but these are not the final values. I intentionally duplicated all variables so it's easy to modify for the final version, otherwise we will be moving around/creating new vars all the time

@N1XUS
Copy link
Contributor

N1XUS commented Apr 26, 2023

@InnaAtanasova I think readonly example is not working since when you click on the checkbox, it's state changes. Maybe you can add some js to prevent checked state to be changed?

@InnaAtanasova
Copy link
Contributor Author

InnaAtanasova commented Apr 26, 2023

@InnaAtanasova I think readonly example is not working since when you click on the checkbox, it's state changes. Maybe you can add some js to prevent checked state to be changed?

@N1XUS it doesn't "work" in main before the changes and the JS was intentionally removed as we had a feedback from users it's misleading to add JS to fund-styles (not even show the code or say about it) when we advertise it as a pure HTML&CSS. The feedback was specifically for the readonly inputs as the user copied the code and it wasn't working on their side.

Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

@droshev droshev requested a review from N1XUS April 26, 2023 18:17
@droshev droshev merged commit ff5c5b3 into main Apr 26, 2023
13 checks passed
@droshev droshev deleted the fix/checkbox-horizon-2023 branch April 26, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Horizon 2023 Horizon Design Changes in 2023
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Component Design Update: Checkbox
3 participants