New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): update Checkbox to latest Horizon 2023 [ci visual] #4480
Conversation
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
--fdCheckbox_Focus_Outline_Offset: 0.25rem; | ||
--fdCheckbox_Outline_Border_Radius: 0.8rem; | ||
--fdCheckbox_Compact_Outline_Border_Radius: 0.5rem; | ||
|
||
// Default | ||
--fdCheckbox_Background_Color_Default: var(--sapField_Background); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the properties can be extracted to the shared variables file, for example, --fdCheckbox_Background_Color_Default: var(--sapField_Background); for horizon and horizon_hc are the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, but these are not the final values. I intentionally duplicated all variables so it's easy to modify for the final version, otherwise we will be moving around/creating new vars all the time
@InnaAtanasova I think readonly example is not working since when you click on the checkbox, it's state changes. Maybe you can add some js to prevent checked state to be changed? |
@N1XUS it doesn't "work" in main before the changes and the JS was intentionally removed as we had a feedback from users it's misleading to add JS to fund-styles (not even show the code or say about it) when we advertise it as a pure HTML&CSS. The feedback was specifically for the readonly inputs as the user copied the code and it wasn't working on their side. |
07ed73e
to
f5ab62c
Compare
f5ab62c
to
0d7dc43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛳️
Related Issue
Closes #4372