fix(styles): screenreaders attempting to read icons from content [ci visual] #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@mikerodonnell89 please fix commit message |
|
@mikerodonnell89 can you enable the visual tests? We need to check if this broke something in the other components. |
mikerodonnell89
changed the title
@N1XUS i think this was a CI hiccup |
@InnaAtanasova done |
InnaAtanasova
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of SAP/fundamental-ngx#9556
Screenreaders try to read the "content" property of CSS pseudoelements, so we are seeing this type of thing on checkboxes and icons:
This PR provides an alternate (empty) value so that the content property is not read.