fix(styles): update Dialog to latest Horizon [ci visual] #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
g-cheishvili
approved these changes
May 22, 2023
Comment on lines
201
to
202
| export const DeviceSpecifications = () => deviceSpecificationsExampleHtml; | ||
| DeviceSpecifications.storyName = 'Tablet and Hybrid Device Specification'; |
There was a problem hiding this comment.
Can you name the story const same as story name and remove DeviceSpecifications.storyName assignment?
InnaAtanasova
force-pushed
the
fix/dialog-horizon-2023
branch
from
0cc7afa
to
d7f9aed
Compare
|
the RTL expander looks off |
InnaAtanasova
force-pushed
the
fix/dialog-horizon-2023
branch
from
d7f9aed
to
0a2a507
Compare
fixed the resize handler in RTL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #4375
Description