Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add RTL support for tabs #642

Merged
merged 2 commits into from
Feb 7, 2020
Merged

fix: Add RTL support for tabs #642

merged 2 commits into from
Feb 7, 2020

Conversation

JKMarkowski
Copy link
Contributor

Related Issue

Closes #639

Description

There is added support for RTL. I mirrored some of padding/margins.

Screenshots

NOTE: If you've made any style changes, please provide appropriate screenshots (before and after) to help reviewers.

To see examples of which screenshots to include, go to Screenshot Examples.

Before:

After:

@netlify
Copy link

netlify bot commented Feb 7, 2020

Deploy preview for fundamental-styles ready!

Built with commit 80012fc

https://deploy-preview-642--fundamental-styles.netlify.com

@droshev droshev added the A11y Accessibility concerns or improvements label Feb 7, 2020
@droshev droshev added this to PRs Reviewer approved in Development via automation Feb 7, 2020
@JKMarkowski JKMarkowski merged commit b2cfa26 into master Feb 7, 2020
Development automation moved this from PRs Reviewer approved to Done Feb 7, 2020
@JKMarkowski JKMarkowski deleted the fix/639-tabs-rtl branch February 7, 2020 14:09
JKMarkowski added a commit that referenced this pull request Feb 7, 2020
* Add RTL support for tabs

* Change count placement in rtl tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Accessibility concerns or improvements
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

Tabs need RTL support
2 participants