Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PushClient.getNotificationStatus() #151

Merged
merged 1 commit into from Dec 5, 2022

Conversation

DirkG68
Copy link
Contributor

@DirkG68 DirkG68 commented Dec 5, 2022

The push services implements the V1 getNotification status method only. Adding list of matching topics too.
Make PushClient.pustToTopic() more robust, allowing empty filter for userIDs

The push services implements the V1 getNotification status method only.
Adding list of matching topics too.
Make PushClient.pustToTopic() more robust, allowing empty filter for
userIDs
@Exotrom
Copy link
Contributor

Exotrom commented Dec 5, 2022

Cool, the topic will be included in the response with 2301, right? Should we release the fix now or wait for the CPMSCF 2301 release?

@DirkG68 DirkG68 merged commit 34575c2 into SAP:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants