Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage with non-blacklisted karma plugins #163

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

mlenkeit
Copy link
Member

@mlenkeit mlenkeit commented Mar 30, 2020

This PR addresses #162.

Instead of preventing the use of karma-ui5 with all other Karma plugins, this PR introduces a blacklist of certain plugins that are not compatible with karma-ui5. These plugins currently include qunit and sinon.

/cc @CCFenner

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2020

CLA assistant check
All committers have signed the CLA.

Co-Authored-By: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
@matz3 matz3 merged commit 1d41181 into SAP:master Mar 31, 2020
@matz3
Copy link
Member

matz3 commented Mar 31, 2020

Thanks 👍

@mlenkeit mlenkeit deleted the allow-multiple-frameworks branch March 31, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants