-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add iframe coverage support #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set karma version back to a stable version with regards to the exitCode
Put karma config into separate file such that it can be required within the karma config, to simplify setting the coverageReporter configuration.
matz3
commented
Jun 10, 2020
test/integration/application-ui5-tooling-iframe/webapp/test/iframepage.html
Outdated
Show resolved
Hide resolved
test/integration/application-ui5-tooling/webapp/test/test.qunit.js
Outdated
Show resolved
Hide resolved
tobiasso85
approved these changes
Jun 16, 2020
matz3
changed the title
[FEATURE] Enable iframe coverage
[FEATURE] Add iframe coverage support
Jun 16, 2020
This fixes #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable iframe coverage reporting.
Add helper option to modify the karma config such that coverage is enabled in iframes.
the config gets enriched with
when calling in file
karma.conf.js
after configuration has been set.
Can only be used in combination with the karma-coverage plugin.
Fixes: #138