Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] README: Add Script Mode configuration to Quickstart Guide #221

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

sbutzek
Copy link
Contributor

@sbutzek sbutzek commented Aug 17, 2020

I had some trouble the other day setting up karma-ui5 in script mode.
I was missing a minimum running example for script mode.
After half a day try-and-error, I found one.
Maybe you also find this helpful for the readme.

I also moved the "mode" section out of "Options" because I think is is a crucial option that stands above all the other options.

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2020

CLA assistant check
All committers have signed the CLA.

@matz3 matz3 self-requested a review August 17, 2020 13:15
@matz3
Copy link
Member

matz3 commented Aug 31, 2020

Thanks @sbutzek 👍🏻
I agree that an example for the script mode was missing.
Instead of documenting the example below the script mode option I've added it to the "Quickstart" guide.
Any feedback welcome!

@matz3 matz3 merged commit 3fe2d4e into SAP:master Sep 1, 2020
@matz3 matz3 changed the title Readme: Move mode section one level up, add minimum running example for script mode [FIX] README: Add Script Mode configuration to Quickstart Guide Sep 1, 2020
@sbutzek
Copy link
Contributor Author

sbutzek commented Sep 21, 2020

Fine for me, thank you @matz3 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants