[FEATURE] Add "failOnEmptyTestPage" option #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@matz3 can you review this change? |
matz3
previously requested changes
Aug 27, 2020
|
@shahzeb79 thanks for the changes. Main change is that now an error is also logged even when to option is not enabled. With v3.0 we should enable this option by default. |
|
@matz3 thanks alot for your changes. Will it be available in v2.2.2 or some else? |
|
v2.3.0, as it's a new feature. We'll do a release once this PR is reviewed and merged. |
RandomByte
approved these changes
Sep 1, 2020
matz3
changed the title
matz3
added a commit
that referenced
this pull request
Sep 2, 2020
PR #228 did not fail because the SauceLabs API key (or any other secure variable) is not available in builds that are triggered from a fork.
matz3
added a commit
that referenced
this pull request
Sep 2, 2020
PR #228 did not fail because the SauceLabs API key (or any other secure variable) is not available in builds that are triggered from a fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#226
Hi colleagues,
In S4 if some team has qunit and opa tests defined and loaded but OPA tests contains no tests or assertion, than runner should fail with error of "Suite with no tests should be removed". This happened when someone comment out testfiles in Alljourneys and runner still loads Alljourney but than reports no tests. In this case we see low coverages and team complains about it. So we want to configure runner so that we centrally can define some parameter in karma conf file to enable or disable failure in case of no tests.
Thanks