Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Creating multiple plugin instances #261

Merged
merged 4 commits into from
Nov 24, 2020
Merged

[FIX] Creating multiple plugin instances #261

merged 4 commits into from
Nov 24, 2020

Conversation

kristian
Copy link
Member

@kristian kristian commented Oct 29, 2020

Recent changes in commit 762cde2 caused that always the same UI5 middleware was returned, even for multiple KarmaServer instances. Karma however, initializes the plugins for each KarmaServer instance, which causes the same middleware to be added twice to the sub-router introduced in the mentioned commit. All in all this causes unexpected behaviour in tests, e.g. failing requests when sending PATCH requests.

@matz3 matz3 self-assigned this Nov 3, 2020
@matz3 matz3 added the bug Something isn't working label Nov 3, 2020
@matz3
Copy link
Member

matz3 commented Nov 10, 2020

Thanks! I think the plugin wasn't really capable of being initialized multiple times and it only worked by chance.

I've added a test and updated the implementation a bit.
Still, the tests need to be extended to ensure that a new framework instance is created every time. I'll try to finish that in the next days.

@matz3 matz3 changed the title Fix running multiple KarmaSevers [FIX] Creating multiple plugin instances Nov 19, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 53.141% when pulling d2200d5 on kristian:master into 6fb7e68 on SAP:master.

@matz3 matz3 merged commit d4e3faa into SAP:master Nov 24, 2020
@matz3
Copy link
Member

matz3 commented Nov 24, 2020

@kristian again, thanks for this PR 👍🏻 It's released with v2.3.2

@kristian
Copy link
Member Author

@matz3 Most welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants