Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Improve rule diffing algorithm #104

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Conversation

tobiasso85
Copy link
Contributor

@tobiasso85 tobiasso85 commented Nov 26, 2019

Diffing algorithm now handles comments between rules correctly

Fixes #105

Diffing algorithm now handles comments between rules correctly
Copy link
Member

@devtomtom devtomtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tobiasso85 tobiasso85 merged commit 2527189 into master Nov 26, 2019
@tobiasso85 tobiasso85 deleted the improve-rule-diff branch November 26, 2019 08:28
tobiasso85 added a commit that referenced this pull request Dec 2, 2019
Test diff algorithm with 2 different css files where the enhanced one has an additional rule and comments.
Tests changes of #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diffing algorithm breaks with comments between rules
2 participants