Support absolute import paths in less files #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeworrior
reviewed
Dec 12, 2019
lib/index.js
Outdated
| const pathname = path.posix.join(currentFileInfo.currentDirectory, file); | ||
| let pathname = path.posix.join(currentFileInfo.currentDirectory, file); | ||
| if (path.isAbsolute(file)) { | ||
| pathname = path.posix.join(file); |
There was a problem hiding this comment.
what is this single join good for? isn't this just a normalize?
There was a problem hiding this comment.
and the join call in L153 is unnecessary for an absolute file, maybe better move it into an else branch.
There was a problem hiding this comment.
shouldn't it be path.posix.isAbsolute?
There was a problem hiding this comment.
shouldn't it be path.posix.isAbsolute?
done with 39df2b1
There was a problem hiding this comment.
LGTM. But I don't know the code enough for an approval.
tobiasso85
changed the title
matz3
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolute import paths are supported with this change
e.g. file
test/fixtures/libraries/scopes/comments/lib3/comments/themes/bar/library.source.less
will be passed as "/lib3/comments/themes/other/sub/my.less" to the filesystem.
Before it was interpreted as a relative path (without the leading slash ("/").
This is especially useful when the filesystem layer is abstracted such as @ui5/fs.