[FEATURE] enable css-vars and skeleton build #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
petermuessig
force-pushed
the
feature-cssvars
branch
from
9cb6a93
to
2e87ede
Compare
add simple and complex scenario. complex scenario has more than one variable and nesting.
matz3
reviewed
Jan 7, 2020
tobiasso85
reviewed
Jan 7, 2020
|
Ah - ok - I will also incorporate your feedback. For now I introduced a library scope for the dynamic variables. This ensures no duplicates across the libraries which could happen in theory. A scoping per theme is not needed as they are not mixed. |
|
Comments are incorporated! |
|
One last thing is to avoid the redundancies in the CSS variables list - let's discuss this briefly... |
matz3
reviewed
Jan 24, 2020
matz3
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable CSS variables support:
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties
can be enabled via compiler option
cssVars