Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] keep linking of less vars for css vars #115

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

petermuessig
Copy link
Contributor

No description provided.

@petermuessig
Copy link
Contributor Author

Hi @matz3

I enhanced the generation of the CSS variables to keep the linking of the raw variable assignment, e.g.

@sapUiFontFamily: @sapFontFamily

:root {
  --sapUiFontFamily: @sapUiFontFamily
}

results in:

: root {
  --sapUiFontFamily: var(--sapFontFamily);
}

This ensures to make the pure linked variables also dependent on the base variables. The calculations will be handled as static values. Here we cannot benefit from the variables feature right now. Maybe something for the future when more calc functions will be available in the browser.

THX and BR,
Peter

@petermuessig petermuessig merged commit 3f99e9d into master Feb 21, 2020
@petermuessig petermuessig deleted the feature-cssvarlinking branch February 21, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants