[FIX] cssVariables: Don't use CSS vars within @font-face directives #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers do not seem to support usage of custom CSS properties (aka CSS variables) within @font-face directives. The skeleton style-sheet should therefore not contain a reference to the variables but just use the actual value provided by the LESS variable. BCP: 2270189546
RandomByte
reviewed
Nov 30, 2022
| @@ -24,6 +25,10 @@ CSSVariablesCollectorPlugin.prototype = { | |||
| return this.mixinStack.length > 0 || this.parenStack.length > 0; | |||
| }, | |||
|
|
|||
| _isInFontFaceDirective() { | |||
| return this.directiveStack.some(({name}) => name === "@font-face"); | |||
There was a problem hiding this comment.
I guess it would be faster to have a dedicated "font-face-directive" stack and check for it's length instead of searching the whole array of directives for every rule? Are directives a rare thing to have in the stack?
RandomByte
approved these changes
Dec 1, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers do not seem to support usage of custom CSS properties
(aka CSS variables) within @font-face directives.
The skeleton style-sheet should therefore not contain a reference to the
variables but just use the actual value provided by the LESS variable.
BCP: 2270189546