Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Scope rule handling #92

Merged
merged 1 commit into from
Sep 26, 2019
Merged

[FIX] Scope rule handling #92

merged 1 commit into from
Sep 26, 2019

Conversation

devtomtom
Copy link
Member

CSS selectors having the scope name added manually (like e.g. in sap/m/BarBase.less) where ignored.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test case and make sure to sign the CLA 👍

@matz3 matz3 added the bug Something isn't working label Sep 25, 2019
@devtomtom devtomtom merged commit 89b56c1 into master Sep 26, 2019
@devtomtom devtomtom deleted the adapt-themebuild-to-rhino branch September 26, 2019 09:36
@matz3 matz3 changed the title Adapt node themebuild to maven build [FIX] Scope rule handling Oct 31, 2019
tobiasso85 added a commit that referenced this pull request Nov 4, 2019
Improve tests such that ".sapContrast" gets taken into account
tobiasso85 added a commit that referenced this pull request Dec 12, 2019
Improve tests such that ".sapContrast" gets taken into account

Followup of (#92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants