Core's navigate to return the navigation result

[aartek]

Description
Navigation using core's Luigi.navigation().navigate() can be stopped if unsaved changes warning modal is displayed and dismissed. Because of that It's hard to perform any action after changing the route - in our case we need to call Luigi.reset() when the route is changed. It would be great if Luigi.navigation().navigate() returned boolean result depends of navigation success.

Then we could do

if (Luigi.navigation().navigate(...)){
    Luigi.reset()
}

Reasons

• add ability to perform action after successful route change

[JohannesDoberer]

Need some clarification first from Philipp

[hardl]

@aartek since the whole navigation mechanism includes a lot of nested asynchronous calls, it is not possible to simply return a boolean.
The proposed solution would be that the navigate function returns a promise, so you could implement your logic from above like

Luigi.navigation().navigate(...).then(() => {
    Luigi.reset()
});

[aartek]

@hardl this will be fine. Do you plan to work on this soon?

[hardl]

@aartek there is already a draft PR https://github.com/SAP/luigi/pull/2417/files, which is waiting to be picked up by someone from the team, so i guess it should be finished soon.