fix: same NeonBee nodeId for multiple instances #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The random NeonBee NODE_ID is the same for all NeonBee instances loaded from the same classloader. This fix makes the NeonBee nodeId an instance variable so that each NeonBee instance has its own nodeId.
|
@halber I think this shouldn't be an issue, only if we would deploy multiple NeonBee instances on the same node... which should never be the case, right? Has this caused any problems in a scenario I am overlooking? |
Right, it is unlikely that anyone would do this except for tests like io.neonbee.NeonBeeExtensionBasedTest#testNeonBeeWithClusters. In this case, you can't distinguish the instances by their IDs. |
s4heid
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The random NeonBee NODE_ID is the same for all NeonBee instances loaded
from the same classloader. This fix makes the NeonBee nodeId an instance
variable so that each NeonBee instance has its own nodeId.