fix: odata query encoding and DataQuery setQuery #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halber
force-pushed
the
fix/odataQueryEncoding
branch
from
312bb9e
to
9feead3
Compare
|
Maybe this is the reason why NeonBee was not able to handle single quotes in the past. Please have a look at 4a0665a This commit contains tests which have failed. Can you add these tests to your change (if you not already have similar ones) to check if this issue is now solved? |
halber
force-pushed
the
fix/odataQueryEncoding
branch
from
9feead3
to
83094ea
Compare
I added the test case, but I had to change it a bit to make the test pass. |
halber
force-pushed
the
fix/odataQueryEncoding
branch
3 times, most recently
from
cbc005e
to
2009459
Compare
halber
force-pushed
the
fix/odataQueryEncoding
branch
3 times, most recently
from
112a0e1
to
27eccee
Compare
The DataQuery expects a decoded query string in the setQuery method and in the constructors that accept a query parameter. These methods are now deprecated since this cannot be fixed. A new method setRawQuery is introduced which accepts the encoded query string and creates the parameters from it.
The parseUri method expects the query parameter to be in percent encoding, but it was decoded.
halber
force-pushed
the
fix/odataQueryEncoding
branch
from
27eccee
to
4d38071
Compare
BenniR6
approved these changes
Nov 4, 2022
BenniR6
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request two problems are fixed
DataQuery cannot correctly process query strings
The DataQuery expects a decoded query string in the setQuery method and
in the constructors that accept a query parameter. These methods are
now deprecated since this cannot be fixed. A new method setRawQuery is
introduced which accepts the encoded query string and creates the
parameters from it.
odata query encoding in EntityVerticle
The parseUri method expects the query parameter to be in percent
encoding, but it was decoded.