Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBI - Enhance ABAP deploy/undeploy flow to support service cli param #1084

Open
3 tasks done
longieirl opened this issue Jun 27, 2023 · 1 comment
Open
3 tasks done
Labels
deploy-tooling @sap-ux/deploy-tooling

Comments

@longieirl
Copy link
Contributor

longieirl commented Jun 27, 2023

Description (include screenshots)

When running the ABAP deploy or undeploy commands, for example

npx deploy --url 'https://server.exmaple' -name ZJLONG0205 --transport 'Y11'  --package  '$tmp' --cloud --cloud-service-env --verbose --no-retry --archive-folder ./dist --noConfig
npx undeploy --url 'https://server.exmaple' --name 'ZJLONG0205' --transport 'Y11' --cloud --cloud-service-env --verbose --no-retry --noConfig

I should be able to append the --service param so that the SAPUI5 Repositroy OData service specified is used instead of the default /sap/opu/odata/UI5/ABAP_REPOSITORY_SRV.

This should also be supported if defined in the ui5-deploy.yaml, for example;

- name: abap-deploy-task
  configuration:
    log: 5
    app:
      name: Z_TEST
      package: $TMP
    target:
      url: https://target.example,
      service: 'bc/myservice'

Value

Improved way of deploying to a ABAP cloud.

Architecture Elaboration

No

Notes

  • axios-extension allows an alias to be passed to the getUi5AbapRepository method when generating the ABAP deploy service.

Tasks

  • Update CLI params to support --service
  • Update readme.md
  • Update test cases
@T1mey
Copy link

T1mey commented Jun 28, 2023

Could you please inform the project piper team to include this parameter into the step transportRequestUploadCTS after it's implemented?

See Params:
https://www.project-piper.io/steps/transportRequestUploadCTS/

@tobiasqueck tobiasqueck added deploy-tooling @sap-ux/deploy-tooling and removed abap-deploy-task labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-tooling @sap-ux/deploy-tooling
Projects
None yet
Development

No branches or pull requests

3 participants