Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the concept of request aborting to timeout based approach #55

Open
flovogt opened this issue Aug 26, 2019 · 0 comments
Open

Changing the concept of request aborting to timeout based approach #55

flovogt opened this issue Aug 26, 2019 · 0 comments
Labels
approved Issue is confirmed as a bug bug Something isn't working

Comments

@flovogt
Copy link
Member

flovogt commented Aug 26, 2019

Introduce request consolidation when bindings are initialized to avoid request aborting and multiple requests with the same URL. The OData model added a timeout mechanism to wait a specific time frame before sending the requests to backend (see
https://github.com/SAP/openui5/blob/master/src/sap.ui.core/src/sap/ui/model/odata/v2/ODataModel.js.

Steps to reproduce this issue:

  1. Clone the sample app https://github.com/SAP-samples/openui5-fhir-sample-app
  2. Run npm run serve
  3. Open the browser and also the dev-tools and filter the network tab by baseR4
  4. Click on http://localhost:8080/index.html#/patients/22790
  5. Now, many requests are aborted which addresses the same resources

image

@flovogt flovogt created this issue from a note in OpenUI5-FHIR - Development (To do) Aug 26, 2019
@flovogt flovogt changed the title **Request Consolidation** Request Consolidation Aug 26, 2019
@flovogt flovogt changed the title Request Consolidation Changing the concept of request aborting to timeout based approach Aug 27, 2019
@flovogt flovogt added approved Issue is confirmed as a bug bug Something isn't working labels Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Issue is confirmed as a bug bug Something isn't working
Projects
Development

No branches or pull requests

1 participant