Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max-width of sap.m.MenuButton #1310

Closed
boghyon opened this issue Jan 23, 2017 · 4 comments
Closed

max-width of sap.m.MenuButton #1310

boghyon opened this issue Jan 23, 2017 · 4 comments
Labels
enhancement fixed

Comments

@boghyon
Copy link
Contributor

boghyon commented Jan 23, 2017

OpenUI5 version: All since MenuButton exists

Tested browsers (OK/FAIL) on Windows 10:
FAIL: FF, IE, Edge, Chrome, Opera
OK: -

URL (minimal example if possible): https://embed.plnkr.co/zXYqbL/

Steps to reproduce the problem:

  1. Visit the provided example page

What is the expected result?
Width of the MenuButton is applied (or auto if no width is given):
expected

What happens instead?
MenuButton has max-width: 12rem.
max-width of MenuButton

Any other information?
Not sure if it's a bug or just not documented.
@hristop
Copy link
Contributor

hristop commented Jan 23, 2017

Hi @boghyon,

Thank you for mentioning this issue.
This is the expected behavior of the sap.m.MenuButton, however, this indeed is not documented anywhere thus we have created internal incident: 1780055997.

Best Regards,

Hristo

@hristop hristop added the fixed label Jan 24, 2017
@hristop
Copy link
Contributor

hristop commented Jan 24, 2017

Hi @boghyon,

The documentation was updated and this will be available in the of the library.

Best Regards,

Hristo

@hristop hristop closed this as completed Jan 24, 2017
@boghyon
Copy link
Contributor Author

boghyon commented Jul 13, 2022

Documentation fixed with baabc9d

@boghyon
Copy link
Contributor Author

boghyon commented Feb 16, 2024

Documentation fixed with baabc9d

... now reverted in this new change 88b563d together with the removal of max-width: 12rem;. Now the sap.m.MenuButton can expand up to 100% width.

boghyon referenced this issue Feb 16, 2024
@NHristov-sap
[FEATURE] sap.m.MenuButton: Removed maximum width of the MenuButton
88b563d 
* until now, there was 12rem maximum width of the MenuButton set,
which leads to truncate of button text if it is longer.

* now the button expands up to 100% of the available space when
necessary.

JIRA: BGSOFUIBALKAN-7770
Change-Id: Ib6e03c14425d83ddf91f74bb2dd3fc00693de224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@codeworrior @boghyon @hristop @i556484