Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the best practice to implement inline edit in sap.m.table? #1646

Closed
TinaC opened this issue Aug 13, 2017 · 2 comments
Closed

What is the best practice to implement inline edit in sap.m.table? #1646

TinaC opened this issue Aug 13, 2017 · 2 comments
Assignees

Comments

@TinaC
Copy link

TinaC commented Aug 13, 2017

Hi,

I am implementing inline edit in sap.m.table, my demo is here: http://plnkr.co/edit/qifky6plPEzFtlpyV2vb?p=preview

I have several questions/concerns:

  1. Is using editable property of sap.m.Input, and enabled property of sap.m.Select the most elegant way to implement this?

  2. In blue crystal, .sapMInputBaseReadonlyInner is using transparent background, so the non-editable state of Input looks just like Text, which looks clean.
    But in belize, .sapMInputBaseReadonlyInner changes to rgba(242,242,242,0.5). It seems no longer suitable to using editable here?

  3. The background color of non-editable state of Input and non-enabled state of Select is different.

It seems Fiori guidelines has not specified these in "Edit Line Items", so I want to listen to your valuable suggestions.

Thanks in advance.

@TinaC
Copy link
Author

TinaC commented Aug 14, 2017

For the third question, using enabled property for both Input and Select will make the color consistent. (I think use editable is more accurate, but sadly, Select does not have editable property.)

I am discussing with our team's designer, who thinks transparent background looks better. But I think overwrite css of library.css is ugly... Looking forward to hear from you experts.

@stephania87
Copy link

The sap.m.Select control does not accept input via typing. My suggestion is to switch to a control inheriting from sap.m.InputBase, which includes an input in its structure.

@TinaC TinaC closed this as completed Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants