New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Credential storing" functionality of iOS not working #2628
Comments
Hi @born2dev , This seems to me like issue in the iOS.
King Regards, |
Hi Lidiya, To be able to control the new iOS features, it it neccessary to set autocomplete attribute on sap.m.input! If not set, iOS tries to figure out username, password, etc. from naming, but this can go wrong! For further info see: Right know there is a autocomplete property only in conjunction with suggestions, but this will be missunderstood. My current workaround is: onInit: function () {
// delegate input autocompletion for passwords
var oPwd = this.byId("new-password"),
oPwdConfirmation = this.byId("confirm-new-password");
oPwd.addEventDelegate({
onAfterRendering: function () {
oPwd.$("inner").attr("autocomplete", "new-password");
//oPwd.$("inner").attr("name", "abc");
}
});
oPwdConfirmation.addEventDelegate({
onAfterRendering: function () {
oPwdConfirmation.$("inner").attr("autocomplete", "new-password");
}
});
} I am also using the sap.m.Wizard for an onboarding szenario which kills usability on iOS, if you use a suggested password. After that, you can not change the pw anymore, because the dialog is showing up, but directly hidden for scroll issues with wizard control. You can only see this, if you use an external keyboard on ipad that the ios helper is flickering around. Maybe someone can put a password field into the wizard sample to test and fix this feature in conjunction with iOS password suggestions. Right know, if you have choosen a suggested password, you are no more able to change it to a new value, because the corresponding dialog will always be hidden for the used eventing inside wizard (i think it is the scrolling). Regards Holger |
Hello @LidiaBobeva, because the example consists of several files, I created it with Plunker: The UI5 application is automatically loaded into the window at the right (takes a few seconds). Then press "login", please. |
Dear UI5-Team, |
Hi born2dev, thank you for your patience and the detailed description of this issue. I've created an internal incident and forwarded it to the responsible development team. Please refer to the following incident ID for further details: The status of this GitHub issue will be updated by the responsible processor. Regards Sebastian |
Can we clarify the steps through https://jsbin.com/litiqeralo/edit?html,output (test URL http://output.jsbin.com/litiqeralo for mobile device)
Thanks |
It's not working on iPhone 8 |
I tested the same steps with iPhone 8 and the username part is filled correctly. Have you tested the same example I posted: https://jsbin.com/litiqeralo/edit?html,output (save a new jsbin to get the output URL for a test) |
Because I myself don't have an iPhone I have to use an iPhone of one of my friends. Today I had the chance to test again. It's an iPhone 8 with iOS 13.1.2. I can hereby confirm that the "Credential storing" functionality works with both your jsbin sample and my Plunker sample. However it still doesn't work with my real application. I need some time to deploy it and then I get back to you. |
I need some more time so don't close this message, please. |
Dear UI5-Team, |
With your app the issue is reproducible. Issues:
|
Thanks for your suggestions. However, to be honest, I don't know what to do. a) b) c) |
Custom code is anything you added on top of the default functionality of controls, e.g. code in event handlers. By custom code here I refer to the external libraries which mess with controls. I am not sure what issue is resolved with rx library, provide a link to a discussion where it is described, including an example. Better in a separate thread The layout issue in the XML is not the source of your issue, but it is better to resolve it. |
I removed all fields except username and password. I also removed the Rx library. After I have deployed it, the issue is still there. |
I was wrong about RX library The app does not work - only the password is returned in the currently focused input. The extracted UI5 code works though, and in autoFillControlsByID I can see both user/pass data https://jsbin.com/sozufanuvi/edit?html,output |
The label "author action" is set. What do I have to do now? If the cause is in my UI5 or JavaScript source text, I need to know what I have to change. |
The point of the thread is to investigate why autopopulation of user/pass on iPhone is not working.
Example3: H2 is changed to H1 in the originally not working example Example4: https://jsbin.com/qavediyeqe/edit?html,output
What is next? I ask in Apple community via forums https://forums.developer.apple.com/message/398626#398626 If you debug and see something else, post an update |
In order that the users of my UI5 application accept the application, it is very important to get this "Credential storing" functionality of iOS working! Unfortunately there has been no response so far from Apple to the question you posted in the Apple community forum. What to do now? |
For the time being, you can illustrate the issue with the isolated HTML examples to your end-users, and provide them the URL of the question. Test if for the list of desired devices+OS changing the title level in the logon helps (customHeader and sap.m.Title with level property set to H1) - https://sapui5.hana.ondemand.com/#/api/sap.m.Dialog%23aggregations You can also run a parallel question for the same. |
Since there is no response from the author for more than year I'm closing the ticket. |
Dear UI5-Team,
my application uses sap.m.Dialog and sap.m.Input to have the user enter their credentials.
On an iPhone 8 + Safari I tried to store the credentials with the help of the "credential storing" functionality of iOS. Both the username and the password are correctly stored; I checked it under settings -> accounts.
However on recalling my application and using this "credential storing" functionality, the password is placed into the username field and the password field stays empty.
On macOS (Mojave) + Safari it works.
OpenUI5: 1.60.12
The text was updated successfully, but these errors were encountered: