sap.m.FeedListItem: iconInitials never worked

[boghyon]

OpenUI5 version

Since the introduction of iconInitials (1.88): 454a41c#diff-8b72ed9ca72d9bf06081308bacffad14f5719bade70ed486635cd5ec2bfabdfa

URL (minimal example if possible)

https://jsbin.com/megaguq/edit?html,js,output

What is the expected result?

Same as initials on sap.m.Avatar: if there is no valid icon (src) set, use the iconInitials.

What happens instead?

Initials are never applied because:

1. sap.m.FeedListItem always sets the person-placeholder icon as fallback:
   

   openui5/src/sap.m/src/sap/m/FeedListItem.js

   Lines 443 to 449 in faaaf27

   	var sIconSrc = sIcon ? sIcon : IconPool.getIconURI("person-placeholder");
   	var sId = this.getId() + '-icon';
   	if (!this.oAvatar) {
   	this.oAvatar = new Avatar({
   	id: sId,
   	src: sIconSrc,

2. sap.m.Avatar, however, applies the initials only if there is no src set.
   

   openui5/src/sap.m/src/sap/m/Avatar.js

   Lines 461 to 476 in faaaf27

   	Avatar.prototype._getActualDisplayType = function () {
   	var sSrc = this.getSrc(),
   	sInitials = this.getInitials();
   	if (sSrc) {
   	this._validateSrc(sSrc);
   	} else if (sInitials && this._areInitialsValid(sInitials)) {
   	this._sActualType = AvatarType.Initials;
   	} else {
   	Log.warning("No src and initials were provided", this);
   	this._sActualType = AvatarType.Icon;
   	this._bIsDefaultIcon = true;
   	}
   	return this._sActualType;
   	};

Any other information? (attach screenshot if possible)

Avatar already uses the icon sap-icon://person-placeholder if its displayShape is Circle (== default shape of FeedListItem's iconDisplayShape). Hence, setting the person placeholder explicitly might be superfluous, unless Square icons are also supposed to display the person placeholder.

[tsanislavgatev]

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident 2180176684. The status of the issue will be updated here in GitHub.
Regards,
Tsanislav

[Madhu552]

Changes is done for this issue with 8aba9a4.

[terezamch]

Hello,

As the issue seem to be fixed by @Madhu552, I am closing the issue.

Best regards,
Tereza