Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom theming no more possible in v1.20.4 (missing base.less) #42

Closed
hschaefer123 opened this issue Apr 25, 2014 · 4 comments
Closed

Comments

@hschaefer123
Copy link

Using 1.18.12 i was able to automatically change blue_theme properties using ant and compile it using less. This was quit nice because i was able to recreate theme on library updates.

Inside 1.20.4 there is a line

@import "../../../../../Base/baseLib/baseTheme/base.less";

including some base parts that are not part of the SDK?!?

I think to be able to create your custom theme this file should also be part of the sdk!

Besides SAPUI5 using the server side theme generator i think inside openui5 it should be possible to create custom themes using less!

Cheers Holger

@machwitt
Copy link
Contributor

Hi Holger,
we are currently discussing how to deal with this issue and we won't have an answer before next week.
Thank you for your patience and have a nice weekend,
Martin

@hschaefer123
Copy link
Author

Any News?

@matz3
Copy link
Member

matz3 commented May 14, 2014

We are still working on a solution.

@matz3
Copy link
Member

matz3 commented Jun 12, 2014

In 1.20.7 there is now again a way to build custom themes with less.

The missing base.less files can now be found in

  • resources/sap/ui/core/themes/base/base.less
  • resources/sap/ui/core/themes/sap_bluecrystal/base.less
  • resources/sap/ui/core/themes/sap_goldreflection/base.less

But you have to manually change the import statements to point to the files above.
I hope this fixes the problem for now.

We are currently still working on a theme concept for OpenUI5 that enables custom theme builds.

Regards,
Matthias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants