-
Notifications
You must be signed in to change notification settings - Fork 47
/
servicebinding_controller.go
1154 lines (1003 loc) · 44.8 KB
/
servicebinding_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package controllers
import (
"context"
"encoding/json"
"strings"
"time"
utils2 "github.com/SAP/sap-btp-service-operator/api/common/utils"
"github.com/pkg/errors"
"github.com/SAP/sap-btp-service-operator/api/common"
"github.com/SAP/sap-btp-service-operator/internal/config"
"github.com/SAP/sap-btp-service-operator/internal/utils"
"github.com/go-logr/logr"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/client-go/tools/record"
"fmt"
"k8s.io/client-go/util/workqueue"
"sigs.k8s.io/controller-runtime/pkg/controller"
servicesv1 "github.com/SAP/sap-btp-service-operator/api/v1"
"k8s.io/apimachinery/pkg/api/meta"
"k8s.io/apimachinery/pkg/runtime/schema"
"github.com/google/uuid"
"github.com/SAP/sap-btp-service-operator/client/sm"
smClientTypes "github.com/SAP/sap-btp-service-operator/client/sm/types"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
)
const (
secretNameTakenErrorFormat = "the specified secret name '%s' is already taken. Choose another name and try again"
secretAlreadyOwnedErrorFormat = "secret %s belongs to another binding %s, choose a different name"
)
// ServiceBindingReconciler reconciles a ServiceBinding object
type ServiceBindingReconciler struct {
client.Client
Log logr.Logger
Scheme *runtime.Scheme
GetSMClient func(ctx context.Context, secretResolver *utils.SecretResolver, resourceNamespace, btpAccessSecretName string) (sm.Client, error)
Config config.Config
SecretResolver *utils.SecretResolver
Recorder record.EventRecorder
}
// +kubebuilder:rbac:groups=services.cloud.sap.com,resources=servicebindings,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=services.cloud.sap.com,resources=servicebindings/status,verbs=get;update;patch
// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=coordination.k8s.io,resources=leases,verbs=get;list;create;update
func (r *ServiceBindingReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
log := r.Log.WithValues("servicebinding", req.NamespacedName).WithValues("correlation_id", uuid.New().String(), req.Name, req.Namespace)
ctx = context.WithValue(ctx, utils.LogKey{}, log)
serviceBinding := &servicesv1.ServiceBinding{}
if err := r.Client.Get(ctx, req.NamespacedName, serviceBinding); err != nil {
if !apierrors.IsNotFound(err) {
log.Error(err, "unable to fetch ServiceBinding")
}
return ctrl.Result{}, client.IgnoreNotFound(err)
}
serviceBinding = serviceBinding.DeepCopy()
log.Info(fmt.Sprintf("Current generation is %v and observed is %v", serviceBinding.Generation, serviceBinding.GetObservedGeneration()))
serviceBinding.SetObservedGeneration(serviceBinding.Generation)
if len(serviceBinding.GetConditions()) == 0 {
if err := utils.InitConditions(ctx, r.Client, serviceBinding); err != nil {
return ctrl.Result{}, err
}
}
serviceInstance, instanceErr := r.getServiceInstanceForBinding(ctx, serviceBinding)
if instanceErr != nil {
if !apierrors.IsNotFound(instanceErr) {
log.Error(instanceErr, "failed to get service instance for binding")
return ctrl.Result{}, instanceErr
} else if !utils.IsMarkedForDeletion(serviceBinding.ObjectMeta) {
//instance is not found and binding is not marked for deletion
instanceNamespace := serviceBinding.Namespace
if len(serviceBinding.Spec.ServiceInstanceNamespace) > 0 {
instanceNamespace = serviceBinding.Spec.ServiceInstanceNamespace
}
errMsg := fmt.Sprintf("couldn't find the service instance '%s' in namespace '%s'", serviceBinding.Spec.ServiceInstanceName, instanceNamespace)
utils.SetBlockedCondition(ctx, errMsg, serviceBinding)
if updateErr := utils.UpdateStatus(ctx, r.Client, serviceBinding); updateErr != nil {
return ctrl.Result{}, updateErr
}
return ctrl.Result{}, instanceErr
}
}
if utils.IsMarkedForDeletion(serviceBinding.ObjectMeta) {
return r.delete(ctx, serviceBinding, serviceInstance.Spec.BTPAccessCredentialsSecret)
}
if len(serviceBinding.Status.OperationURL) > 0 {
// ongoing operation - poll status from SM
return r.poll(ctx, serviceBinding, serviceInstance.Spec.BTPAccessCredentialsSecret)
}
if !controllerutil.ContainsFinalizer(serviceBinding, common.FinalizerName) {
controllerutil.AddFinalizer(serviceBinding, common.FinalizerName)
log.Info(fmt.Sprintf("added finalizer '%s' to service binding", common.FinalizerName))
if err := r.Client.Update(ctx, serviceBinding); err != nil {
return ctrl.Result{}, err
}
}
condition := meta.FindStatusCondition(serviceBinding.Status.Conditions, common.ConditionReady)
if serviceBinding.Status.BindingID != "" && condition != nil && condition.ObservedGeneration != serviceBinding.Generation {
err := r.updateSecret(ctx, serviceBinding, serviceInstance, log)
if err != nil {
return r.handleSecretError(ctx, smClientTypes.UPDATE, err, serviceBinding)
}
err = utils.UpdateStatus(ctx, r.Client, serviceBinding)
if err != nil {
return r.handleSecretError(ctx, smClientTypes.UPDATE, err, serviceBinding)
}
}
isBindingReady := condition != nil && condition.Status == metav1.ConditionTrue
if isBindingReady {
if isStaleServiceBinding(serviceBinding) {
return r.handleStaleServiceBinding(ctx, serviceBinding)
}
if initCredRotationIfRequired(serviceBinding) {
return ctrl.Result{}, utils.UpdateStatus(ctx, r.Client, serviceBinding)
}
}
if meta.IsStatusConditionTrue(serviceBinding.Status.Conditions, common.ConditionCredRotationInProgress) {
if err := r.rotateCredentials(ctx, serviceBinding, serviceInstance.Spec.BTPAccessCredentialsSecret); err != nil {
return ctrl.Result{}, err
}
}
if isBindingReady {
log.Info("Binding in final state")
return r.maintain(ctx, serviceBinding)
}
if serviceNotUsable(serviceInstance) {
instanceErr := fmt.Errorf("service instance '%s' is not usable", serviceBinding.Spec.ServiceInstanceName)
utils.SetBlockedCondition(ctx, instanceErr.Error(), serviceBinding)
if err := utils.UpdateStatus(ctx, r.Client, serviceBinding); err != nil {
return ctrl.Result{}, err
}
return ctrl.Result{}, instanceErr
}
if utils.IsInProgress(serviceInstance) {
log.Info(fmt.Sprintf("Service instance with k8s name %s is not ready for binding yet", serviceInstance.Name))
utils.SetInProgressConditions(ctx, smClientTypes.CREATE, fmt.Sprintf("creation in progress, waiting for service instance '%s' to be ready", serviceBinding.Spec.ServiceInstanceName), serviceBinding)
return ctrl.Result{Requeue: true, RequeueAfter: r.Config.PollInterval}, utils.UpdateStatus(ctx, r.Client, serviceBinding)
}
//set owner instance only for original bindings (not rotated)
if serviceBinding.Labels == nil || len(serviceBinding.Labels[common.StaleBindingIDLabel]) == 0 {
if !bindingAlreadyOwnedByInstance(serviceInstance, serviceBinding) &&
serviceInstance.Namespace == serviceBinding.Namespace { //cross namespace reference not allowed
if err := r.setOwner(ctx, serviceInstance, serviceBinding); err != nil {
log.Error(err, "failed to set owner reference for binding")
return ctrl.Result{}, err
}
}
}
if serviceBinding.Status.BindingID == "" {
if err := r.validateSecretNameIsAvailable(ctx, serviceBinding); err != nil {
utils.SetBlockedCondition(ctx, err.Error(), serviceBinding)
return ctrl.Result{}, utils.UpdateStatus(ctx, r.Client, serviceBinding)
}
smClient, err := r.GetSMClient(ctx, r.SecretResolver, serviceBinding.Namespace, serviceInstance.Spec.BTPAccessCredentialsSecret)
if err != nil {
return utils.MarkAsTransientError(ctx, r.Client, common.Unknown, err, serviceBinding)
}
smBinding, err := r.getBindingForRecovery(ctx, smClient, serviceBinding)
if err != nil {
log.Error(err, "failed to check binding recovery")
return utils.MarkAsTransientError(ctx, r.Client, smClientTypes.CREATE, err, serviceBinding)
}
if smBinding != nil {
return r.recover(ctx, serviceBinding, smBinding)
}
return r.createBinding(ctx, smClient, serviceInstance, serviceBinding)
}
log.Error(fmt.Errorf("update binding is not allowed, this line should not be reached"), "")
return ctrl.Result{}, nil
}
func (r *ServiceBindingReconciler) updateSecret(ctx context.Context, serviceBinding *servicesv1.ServiceBinding, serviceInstance *servicesv1.ServiceInstance, log logr.Logger) error {
log.Info("Updating secret according to the new template")
smClient, err := r.GetSMClient(ctx, r.SecretResolver, serviceBinding.Namespace, serviceInstance.Spec.BTPAccessCredentialsSecret)
if err != nil {
return err
}
smBinding, err := smClient.GetBindingByID(serviceBinding.Status.BindingID, nil)
if err != nil {
log.Error(err, "failed to get binding for update secret")
return err
}
if smBinding != nil {
if smBinding.Credentials != nil {
if err = r.storeBindingSecret(ctx, serviceBinding, smBinding); err != nil {
return err
}
log.Info("Updating binding", "bindingID", smBinding.ID)
utils.SetSuccessConditions(smClientTypes.UPDATE, serviceBinding)
}
}
return nil
}
func (r *ServiceBindingReconciler) SetupWithManager(mgr ctrl.Manager) error {
return ctrl.NewControllerManagedBy(mgr).
For(&servicesv1.ServiceBinding{}).
WithOptions(controller.Options{RateLimiter: workqueue.NewItemExponentialFailureRateLimiter(r.Config.RetryBaseDelay, r.Config.RetryMaxDelay)}).
Complete(r)
}
func (r *ServiceBindingReconciler) createBinding(ctx context.Context, smClient sm.Client, serviceInstance *servicesv1.ServiceInstance, serviceBinding *servicesv1.ServiceBinding) (ctrl.Result, error) {
log := utils.GetLogger(ctx)
log.Info("Creating smBinding in SM")
serviceBinding.Status.InstanceID = serviceInstance.Status.InstanceID
_, bindingParameters, err := utils.BuildSMRequestParameters(r.Client, serviceBinding.Namespace, serviceBinding.Spec.ParametersFrom, serviceBinding.Spec.Parameters)
if err != nil {
log.Error(err, "failed to parse smBinding parameters")
return utils.MarkAsNonTransientError(ctx, r.Client, smClientTypes.CREATE, err.Error(), serviceBinding)
}
smBinding, operationURL, bindErr := smClient.Bind(&smClientTypes.ServiceBinding{
Name: serviceBinding.Spec.ExternalName,
Labels: smClientTypes.Labels{
common.NamespaceLabel: []string{serviceBinding.Namespace},
common.K8sNameLabel: []string{serviceBinding.Name},
common.ClusterIDLabel: []string{r.Config.ClusterID},
},
ServiceInstanceID: serviceInstance.Status.InstanceID,
Parameters: bindingParameters,
}, nil, utils.BuildUserInfo(ctx, serviceBinding.Spec.UserInfo))
if bindErr != nil {
log.Error(err, "failed to create service binding", "serviceInstanceID", serviceInstance.Status.InstanceID)
return utils.HandleError(ctx, r.Client, smClientTypes.CREATE, bindErr, serviceBinding, true)
}
if operationURL != "" {
var bindingID string
if bindingID = sm.ExtractBindingID(operationURL); len(bindingID) == 0 {
return utils.MarkAsNonTransientError(ctx, r.Client, smClientTypes.CREATE, fmt.Sprintf("failed to extract smBinding ID from operation URL %s", operationURL), serviceBinding)
}
serviceBinding.Status.BindingID = bindingID
log.Info("Create smBinding request is async")
serviceBinding.Status.OperationURL = operationURL
serviceBinding.Status.OperationType = smClientTypes.CREATE
utils.SetInProgressConditions(ctx, smClientTypes.CREATE, "", serviceBinding)
if err := utils.UpdateStatus(ctx, r.Client, serviceBinding); err != nil {
log.Error(err, "unable to update ServiceBinding status")
return ctrl.Result{}, err
}
return ctrl.Result{Requeue: true, RequeueAfter: r.Config.PollInterval}, nil
}
log.Info("Binding created successfully")
if err := r.storeBindingSecret(ctx, serviceBinding, smBinding); err != nil {
return r.handleSecretError(ctx, smClientTypes.CREATE, err, serviceBinding)
}
subaccountID := ""
if len(smBinding.Labels["subaccount_id"]) > 0 {
subaccountID = smBinding.Labels["subaccount_id"][0]
}
serviceBinding.Status.BindingID = smBinding.ID
serviceBinding.Status.SubaccountID = subaccountID
serviceBinding.Status.Ready = metav1.ConditionTrue
utils.SetSuccessConditions(smClientTypes.CREATE, serviceBinding)
log.Info("Updating binding", "bindingID", smBinding.ID)
return ctrl.Result{}, utils.UpdateStatus(ctx, r.Client, serviceBinding)
}
func (r *ServiceBindingReconciler) delete(ctx context.Context, serviceBinding *servicesv1.ServiceBinding, btpAccessCredentialsSecret string) (ctrl.Result, error) {
log := utils.GetLogger(ctx)
if controllerutil.ContainsFinalizer(serviceBinding, common.FinalizerName) {
smClient, err := r.GetSMClient(ctx, r.SecretResolver, serviceBinding.Namespace, btpAccessCredentialsSecret)
if err != nil {
return utils.MarkAsTransientError(ctx, r.Client, common.Unknown, err, serviceBinding)
}
if len(serviceBinding.Status.BindingID) == 0 {
log.Info("No binding id found validating binding does not exists in SM before removing finalizer")
smBinding, err := r.getBindingForRecovery(ctx, smClient, serviceBinding)
if err != nil {
return ctrl.Result{}, err
}
if smBinding != nil {
log.Info("binding exists in SM continue with deletion")
serviceBinding.Status.BindingID = smBinding.ID
utils.SetInProgressConditions(ctx, smClientTypes.DELETE, "delete after recovery", serviceBinding)
return ctrl.Result{}, utils.UpdateStatus(ctx, r.Client, serviceBinding)
}
// make sure there's no secret stored for the binding
if err := r.deleteBindingSecret(ctx, serviceBinding); err != nil {
return ctrl.Result{}, err
}
log.Info("Binding does not exists in SM, removing finalizer")
if err := utils.RemoveFinalizer(ctx, r.Client, serviceBinding, common.FinalizerName); err != nil {
return ctrl.Result{}, err
}
return ctrl.Result{}, nil
}
if len(serviceBinding.Status.OperationURL) > 0 && serviceBinding.Status.OperationType == smClientTypes.DELETE {
// ongoing delete operation - poll status from SM
return r.poll(ctx, serviceBinding, btpAccessCredentialsSecret)
}
log.Info(fmt.Sprintf("Deleting binding with id %v from SM", serviceBinding.Status.BindingID))
operationURL, unbindErr := smClient.Unbind(serviceBinding.Status.BindingID, nil, utils.BuildUserInfo(ctx, serviceBinding.Spec.UserInfo))
if unbindErr != nil {
// delete will proceed anyway
return utils.MarkAsNonTransientError(ctx, r.Client, smClientTypes.DELETE, unbindErr.Error(), serviceBinding)
}
if operationURL != "" {
log.Info("Deleting binding async")
serviceBinding.Status.OperationURL = operationURL
serviceBinding.Status.OperationType = smClientTypes.DELETE
utils.SetInProgressConditions(ctx, smClientTypes.DELETE, "", serviceBinding)
if err := utils.UpdateStatus(ctx, r.Client, serviceBinding); err != nil {
return ctrl.Result{}, err
}
return ctrl.Result{Requeue: true, RequeueAfter: r.Config.PollInterval}, nil
}
log.Info("Binding was deleted successfully")
return r.deleteSecretAndRemoveFinalizer(ctx, serviceBinding)
}
return ctrl.Result{}, nil
}
func (r *ServiceBindingReconciler) poll(ctx context.Context, serviceBinding *servicesv1.ServiceBinding, btpAccessCredentialsSecret string) (ctrl.Result, error) {
log := utils.GetLogger(ctx)
log.Info(fmt.Sprintf("resource is in progress, found operation url %s", serviceBinding.Status.OperationURL))
smClient, err := r.GetSMClient(ctx, r.SecretResolver, serviceBinding.Namespace, btpAccessCredentialsSecret)
if err != nil {
return utils.MarkAsTransientError(ctx, r.Client, common.Unknown, err, serviceBinding)
}
status, statusErr := smClient.Status(serviceBinding.Status.OperationURL, nil)
if statusErr != nil {
log.Info(fmt.Sprintf("failed to fetch operation, got error from SM: %s", statusErr.Error()), "operationURL", serviceBinding.Status.OperationURL)
utils.SetFailureConditions(serviceBinding.Status.OperationType, statusErr.Error(), serviceBinding)
freshStatus := servicesv1.ServiceBindingStatus{
Conditions: serviceBinding.GetConditions(),
}
if utils.IsMarkedForDeletion(serviceBinding.ObjectMeta) {
freshStatus.BindingID = serviceBinding.Status.BindingID
}
serviceBinding.Status = freshStatus
if err := utils.UpdateStatus(ctx, r.Client, serviceBinding); err != nil {
log.Error(err, "failed to update status during polling")
}
return ctrl.Result{}, statusErr
}
if status == nil {
return utils.MarkAsTransientError(ctx, r.Client, serviceBinding.Status.OperationType, fmt.Errorf("failed to get last operation status of %s", serviceBinding.Name), serviceBinding)
}
switch status.State {
case smClientTypes.INPROGRESS:
fallthrough
case smClientTypes.PENDING:
if len(status.Description) != 0 {
utils.SetInProgressConditions(ctx, status.Type, status.Description, serviceBinding)
if err := utils.UpdateStatus(ctx, r.Client, serviceBinding); err != nil {
log.Error(err, "unable to update ServiceBinding polling description")
return ctrl.Result{}, err
}
}
return ctrl.Result{Requeue: true, RequeueAfter: r.Config.PollInterval}, nil
case smClientTypes.FAILED:
// non transient error - should not retry
utils.SetFailureConditions(status.Type, status.Description, serviceBinding)
if serviceBinding.Status.OperationType == smClientTypes.DELETE {
serviceBinding.Status.OperationURL = ""
serviceBinding.Status.OperationType = ""
if err := utils.UpdateStatus(ctx, r.Client, serviceBinding); err != nil {
log.Error(err, "unable to update ServiceBinding status")
return ctrl.Result{}, err
}
errMsg := "Async unbind operation failed"
if status.Errors != nil {
errMsg = fmt.Sprintf("Async unbind operation failed, errors: %s", string(status.Errors))
}
return ctrl.Result{}, fmt.Errorf(errMsg)
}
case smClientTypes.SUCCEEDED:
utils.SetSuccessConditions(status.Type, serviceBinding)
switch serviceBinding.Status.OperationType {
case smClientTypes.CREATE:
smBinding, err := smClient.GetBindingByID(serviceBinding.Status.BindingID, nil)
if err != nil || smBinding == nil {
log.Error(err, fmt.Sprintf("binding %s succeeded but could not fetch it from SM", serviceBinding.Status.BindingID))
return ctrl.Result{}, err
}
if len(smBinding.Labels["subaccount_id"]) > 0 {
serviceBinding.Status.SubaccountID = smBinding.Labels["subaccount_id"][0]
}
if err := r.storeBindingSecret(ctx, serviceBinding, smBinding); err != nil {
return r.handleSecretError(ctx, smClientTypes.CREATE, err, serviceBinding)
}
utils.SetSuccessConditions(status.Type, serviceBinding)
case smClientTypes.DELETE:
return r.deleteSecretAndRemoveFinalizer(ctx, serviceBinding)
}
}
serviceBinding.Status.OperationURL = ""
serviceBinding.Status.OperationType = ""
return ctrl.Result{}, utils.UpdateStatus(ctx, r.Client, serviceBinding)
}
func (r *ServiceBindingReconciler) getBindingForRecovery(ctx context.Context, smClient sm.Client, serviceBinding *servicesv1.ServiceBinding) (*smClientTypes.ServiceBinding, error) {
log := utils.GetLogger(ctx)
nameQuery := fmt.Sprintf("name eq '%s'", serviceBinding.Spec.ExternalName)
clusterIDQuery := fmt.Sprintf("context/clusterid eq '%s'", r.Config.ClusterID)
namespaceQuery := fmt.Sprintf("context/namespace eq '%s'", serviceBinding.Namespace)
k8sNameQuery := fmt.Sprintf("%s eq '%s'", common.K8sNameLabel, serviceBinding.Name)
parameters := sm.Parameters{
FieldQuery: []string{nameQuery, clusterIDQuery, namespaceQuery},
LabelQuery: []string{k8sNameQuery},
GeneralParams: []string{"attach_last_operations=true"},
}
log.Info(fmt.Sprintf("binding recovery query params: %s, %s, %s, %s", nameQuery, clusterIDQuery, namespaceQuery, k8sNameQuery))
bindings, err := smClient.ListBindings(¶meters)
if err != nil {
log.Error(err, "failed to list bindings in SM")
return nil, err
}
if bindings != nil {
log.Info(fmt.Sprintf("found %d bindings", len(bindings.ServiceBindings)))
if len(bindings.ServiceBindings) == 1 {
return &bindings.ServiceBindings[0], nil
}
}
return nil, nil
}
func (r *ServiceBindingReconciler) maintain(ctx context.Context, binding *servicesv1.ServiceBinding) (ctrl.Result, error) {
log := utils.GetLogger(ctx)
shouldUpdateStatus := false
if binding.Generation != binding.Status.ObservedGeneration {
binding.SetObservedGeneration(binding.Generation)
shouldUpdateStatus = true
}
if !utils.IsFailed(binding) {
if _, err := r.getSecret(ctx, binding.Namespace, binding.Spec.SecretName); err != nil {
if apierrors.IsNotFound(err) && !utils.IsMarkedForDeletion(binding.ObjectMeta) {
log.Info(fmt.Sprintf("secret not found recovering binding %s", binding.Name))
binding.Status.BindingID = ""
binding.Status.Ready = metav1.ConditionFalse
utils.SetInProgressConditions(ctx, smClientTypes.CREATE, "recreating deleted secret", binding)
shouldUpdateStatus = true
r.Recorder.Event(binding, corev1.EventTypeWarning, "SecretDeleted", "SecretDeleted")
} else {
return ctrl.Result{}, err
}
}
}
if shouldUpdateStatus {
log.Info(fmt.Sprintf("maintanance required for binding %s", binding.Name))
return ctrl.Result{}, utils.UpdateStatus(ctx, r.Client, binding)
}
return ctrl.Result{}, nil
}
func (r *ServiceBindingReconciler) getServiceInstanceForBinding(ctx context.Context, binding *servicesv1.ServiceBinding) (*servicesv1.ServiceInstance, error) {
log := utils.GetLogger(ctx)
serviceInstance := &servicesv1.ServiceInstance{}
namespace := binding.Namespace
if len(binding.Spec.ServiceInstanceNamespace) > 0 {
namespace = binding.Spec.ServiceInstanceNamespace
}
log.Info(fmt.Sprintf("getting service instance named %s in namespace %s for binding %s in namespace %s", binding.Spec.ServiceInstanceName, namespace, binding.Name, binding.Namespace))
if err := r.Client.Get(ctx, types.NamespacedName{Name: binding.Spec.ServiceInstanceName, Namespace: namespace}, serviceInstance); err != nil {
return serviceInstance, err
}
return serviceInstance.DeepCopy(), nil
}
func (r *ServiceBindingReconciler) setOwner(ctx context.Context, serviceInstance *servicesv1.ServiceInstance, serviceBinding *servicesv1.ServiceBinding) error {
log := utils.GetLogger(ctx)
log.Info("Binding instance as owner of binding", "bindingName", serviceBinding.Name, "instanceName", serviceInstance.Name)
if err := controllerutil.SetControllerReference(serviceInstance, serviceBinding, r.Scheme); err != nil {
log.Error(err, fmt.Sprintf("Could not update the smBinding %s owner instance reference", serviceBinding.Name))
return err
}
if err := r.Client.Update(ctx, serviceBinding); err != nil {
log.Error(err, "Failed to set controller reference", "bindingName", serviceBinding.Name)
return err
}
return nil
}
func (r *ServiceBindingReconciler) resyncBindingStatus(ctx context.Context, k8sBinding *servicesv1.ServiceBinding, smBinding *smClientTypes.ServiceBinding) {
k8sBinding.Status.ObservedGeneration = k8sBinding.Generation
k8sBinding.Status.BindingID = smBinding.ID
k8sBinding.Status.InstanceID = smBinding.ServiceInstanceID
k8sBinding.Status.OperationURL = ""
k8sBinding.Status.OperationType = ""
bindingStatus := smClientTypes.SUCCEEDED
operationType := smClientTypes.CREATE
description := ""
if smBinding.LastOperation != nil {
bindingStatus = smBinding.LastOperation.State
operationType = smBinding.LastOperation.Type
description = smBinding.LastOperation.Description
} else if !smBinding.Ready {
bindingStatus = smClientTypes.FAILED
}
switch bindingStatus {
case smClientTypes.PENDING:
fallthrough
case smClientTypes.INPROGRESS:
k8sBinding.Status.OperationURL = sm.BuildOperationURL(smBinding.LastOperation.ID, smBinding.ID, smClientTypes.ServiceBindingsURL)
k8sBinding.Status.OperationType = smBinding.LastOperation.Type
utils.SetInProgressConditions(ctx, smBinding.LastOperation.Type, smBinding.LastOperation.Description, k8sBinding)
case smClientTypes.SUCCEEDED:
utils.SetSuccessConditions(operationType, k8sBinding)
case smClientTypes.FAILED:
utils.SetFailureConditions(operationType, description, k8sBinding)
}
}
func (r *ServiceBindingReconciler) storeBindingSecret(ctx context.Context, k8sBinding *servicesv1.ServiceBinding, smBinding *smClientTypes.ServiceBinding) error {
log := utils.GetLogger(ctx)
logger := log.WithValues("bindingName", k8sBinding.Name, "secretName", k8sBinding.Spec.SecretName)
var secret *corev1.Secret
var err error
if k8sBinding.Spec.SecretTemplate != "" {
secret, err = r.createBindingSecretFromSecretTemplate(ctx, k8sBinding, smBinding.Credentials)
} else {
secret, err = r.createBindingSecret(ctx, k8sBinding, smBinding)
}
if err != nil {
return err
}
if err = controllerutil.SetControllerReference(k8sBinding, secret, r.Scheme); err != nil {
logger.Error(err, "Failed to set secret owner")
return err
}
return r.createOrUpdateBindingSecret(ctx, k8sBinding, secret)
}
func (r *ServiceBindingReconciler) createBindingSecret(ctx context.Context, k8sBinding *servicesv1.ServiceBinding, smBinding *smClientTypes.ServiceBinding) (*corev1.Secret, error) {
log := utils.GetLogger(ctx)
logger := log.WithValues("bindingName", k8sBinding.Name, "secretName", k8sBinding.Spec.SecretName)
var credentialsMap map[string][]byte
var credentialProperties []utils.SecretMetadataProperty
if len(smBinding.Credentials) == 0 {
log.Info("Binding credentials are empty")
credentialsMap = make(map[string][]byte)
} else if k8sBinding.Spec.SecretKey != nil {
credentialsMap = map[string][]byte{
*k8sBinding.Spec.SecretKey: smBinding.Credentials,
}
credentialProperties = []utils.SecretMetadataProperty{
{
Name: *k8sBinding.Spec.SecretKey,
Format: string(utils.JSON),
Container: true,
},
}
} else {
var err error
credentialsMap, credentialProperties, err = utils.NormalizeCredentials(smBinding.Credentials)
if err != nil {
logger.Error(err, "Failed to store binding secret")
return nil, fmt.Errorf("failed to create secret. Error: %v", err.Error())
}
}
metaDataProperties, err := r.addInstanceInfo(ctx, k8sBinding, credentialsMap)
if err != nil {
log.Error(err, "failed to enrich binding with service instance info")
}
if k8sBinding.Spec.SecretRootKey != nil {
var err error
credentialsMap, err = singleKeyMap(credentialsMap, *k8sBinding.Spec.SecretRootKey)
if err != nil {
return nil, err
}
} else {
metadata := map[string][]utils.SecretMetadataProperty{
"metaDataProperties": metaDataProperties,
"credentialProperties": credentialProperties,
}
metadataByte, err := json.Marshal(metadata)
if err != nil {
log.Error(err, "failed to enrich binding with metadata")
} else {
credentialsMap[".metadata"] = metadataByte
}
}
secret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: k8sBinding.Spec.SecretName,
Annotations: map[string]string{"binding": k8sBinding.Name},
Namespace: k8sBinding.Namespace,
},
Data: credentialsMap,
}
return secret, nil
}
func (r *ServiceBindingReconciler) createBindingSecretFromSecretTemplate(ctx context.Context, k8sBinding *servicesv1.ServiceBinding, inputSmCredentials json.RawMessage) (*corev1.Secret, error) {
log := utils.GetLogger(ctx)
logger := log.WithValues("bindingName", k8sBinding.Name, "secretName", k8sBinding.Spec.SecretName)
logger.Info("Create Object using SecretTemplate from ServiceBinding Specs")
smBindingCredentials := make(map[string]interface{})
if inputSmCredentials != nil {
err := json.Unmarshal(inputSmCredentials, &smBindingCredentials)
if err != nil {
logger.Error(err, "failed to unmarshal given service binding credentials")
return nil, errors.Wrap(err, "failed to unmarshal given service binding credentials")
}
}
instanceInfos, err := r.getInstanceInfo(ctx, k8sBinding)
if err != nil {
logger.Error(err, "failed to addInstanceInfo")
return nil, errors.Wrap(err, "failed to add service instance info")
}
parameters := utils2.GetSecretDataForTemplate(smBindingCredentials, instanceInfos)
templateName := fmt.Sprintf("%s/%s", k8sBinding.Namespace, k8sBinding.Name)
secret, err := utils2.CreateSecretFromTemplate(templateName, k8sBinding.Spec.SecretTemplate, "missingkey=error", parameters)
if err != nil {
logger.Error(err, "failed to create secret from template")
return nil, errors.Wrap(err, "failed to create secret from template")
}
secret.SetNamespace(k8sBinding.Namespace)
secret.SetName(k8sBinding.Spec.SecretName)
return secret, nil
}
func (r *ServiceBindingReconciler) createOrUpdateBindingSecret(ctx context.Context, binding *servicesv1.ServiceBinding, secret *corev1.Secret) error {
log := utils.GetLogger(ctx)
dbSecret := &corev1.Secret{}
create := false
if err := r.Client.Get(ctx, types.NamespacedName{Name: binding.Spec.SecretName, Namespace: binding.Namespace}, dbSecret); err != nil {
if !apierrors.IsNotFound(err) {
return err
}
create = true
}
if create {
log.Info("Creating binding secret", "name", secret.Name)
if err := r.Client.Create(ctx, secret); err != nil {
if !apierrors.IsAlreadyExists(err) {
return err
}
return nil
}
r.Recorder.Event(binding, corev1.EventTypeNormal, "SecretCreated", "SecretCreated")
return nil
}
log.Info("Updating existing binding secret", "name", secret.Name)
dbSecret.Data = secret.Data
dbSecret.StringData = secret.StringData
dbSecret.Labels = secret.Labels
dbSecret.Annotations = secret.Annotations
return r.Client.Update(ctx, dbSecret)
}
func (r *ServiceBindingReconciler) deleteBindingSecret(ctx context.Context, binding *servicesv1.ServiceBinding) error {
log := utils.GetLogger(ctx)
log.Info("Deleting binding secret")
bindingSecret := &corev1.Secret{}
if err := r.Client.Get(ctx, types.NamespacedName{
Namespace: binding.Namespace,
Name: binding.Spec.SecretName,
}, bindingSecret); err != nil {
if !apierrors.IsNotFound(err) {
log.Error(err, "unable to fetch binding secret")
return err
}
// secret not found, nothing more to do
log.Info("secret was deleted successfully")
return nil
}
bindingSecret = bindingSecret.DeepCopy()
if err := r.Client.Delete(ctx, bindingSecret); err != nil {
log.Error(err, "Failed to delete binding secret")
return err
}
log.Info("secret was deleted successfully")
return nil
}
func (r *ServiceBindingReconciler) deleteSecretAndRemoveFinalizer(ctx context.Context, serviceBinding *servicesv1.ServiceBinding) (ctrl.Result, error) {
// delete binding secret if exist
if err := r.deleteBindingSecret(ctx, serviceBinding); err != nil {
return ctrl.Result{}, err
}
return ctrl.Result{}, utils.RemoveFinalizer(ctx, r.Client, serviceBinding, common.FinalizerName)
}
func (r *ServiceBindingReconciler) getSecret(ctx context.Context, namespace string, name string) (*corev1.Secret, error) {
secret := &corev1.Secret{}
err := r.Client.Get(ctx, types.NamespacedName{Namespace: namespace, Name: name}, secret)
return secret, err
}
func (r *ServiceBindingReconciler) validateSecretNameIsAvailable(ctx context.Context, binding *servicesv1.ServiceBinding) error {
currentSecret, err := r.getSecret(ctx, binding.Namespace, binding.Spec.SecretName)
if err != nil {
return client.IgnoreNotFound(err)
}
if metav1.IsControlledBy(currentSecret, binding) {
return nil
}
ownerRef := metav1.GetControllerOf(currentSecret)
if ownerRef != nil {
owner, err := schema.ParseGroupVersion(ownerRef.APIVersion)
if err != nil {
return err
}
if owner.Group == binding.GroupVersionKind().Group && ownerRef.Kind == binding.Kind {
return fmt.Errorf(secretAlreadyOwnedErrorFormat, binding.Spec.SecretName, ownerRef.Name)
}
}
return fmt.Errorf(secretNameTakenErrorFormat, binding.Spec.SecretName)
}
func (r *ServiceBindingReconciler) handleSecretError(ctx context.Context, op smClientTypes.OperationCategory, err error, binding *servicesv1.ServiceBinding) (ctrl.Result, error) {
log := utils.GetLogger(ctx)
log.Error(err, fmt.Sprintf("failed to store secret %s for binding %s", binding.Spec.SecretName, binding.Name))
if apierrors.ReasonForError(err) == metav1.StatusReasonUnknown {
return utils.MarkAsNonTransientError(ctx, r.Client, op, err.Error(), binding)
}
return utils.MarkAsTransientError(ctx, r.Client, op, err, binding)
}
func (r *ServiceBindingReconciler) getInstanceInfo(ctx context.Context, binding *servicesv1.ServiceBinding) (map[string]string, error) {
instance, err := r.getServiceInstanceForBinding(ctx, binding)
if err != nil {
return nil, err
}
instanceInfos := make(map[string]string)
instanceInfos["instance_name"] = string(getInstanceNameForSecretCredentials(instance))
instanceInfos["instance_guid"] = instance.Status.InstanceID
instanceInfos["plan"] = instance.Spec.ServicePlanName
instanceInfos["label"] = instance.Spec.ServiceOfferingName
instanceInfos["type"] = instance.Spec.ServiceOfferingName
if len(instance.Status.Tags) > 0 || len(instance.Spec.CustomTags) > 0 {
tags := mergeInstanceTags(instance.Status.Tags, instance.Spec.CustomTags)
instanceInfos["tags"] = strings.Join(tags, ",")
}
return instanceInfos, nil
}
func (r *ServiceBindingReconciler) addInstanceInfo(ctx context.Context, binding *servicesv1.ServiceBinding, credentialsMap map[string][]byte) ([]utils.SecretMetadataProperty, error) {
instance, err := r.getServiceInstanceForBinding(ctx, binding)
if err != nil {
return nil, err
}
credentialsMap["instance_name"] = getInstanceNameForSecretCredentials(instance)
credentialsMap["instance_guid"] = []byte(instance.Status.InstanceID)
credentialsMap["plan"] = []byte(instance.Spec.ServicePlanName)
credentialsMap["label"] = []byte(instance.Spec.ServiceOfferingName)
credentialsMap["type"] = []byte(instance.Spec.ServiceOfferingName)
if len(instance.Status.Tags) > 0 || len(instance.Spec.CustomTags) > 0 {
tagsBytes, err := json.Marshal(mergeInstanceTags(instance.Status.Tags, instance.Spec.CustomTags))
if err != nil {
return nil, err
}
credentialsMap["tags"] = tagsBytes
}
metadata := []utils.SecretMetadataProperty{
{
Name: "instance_name",
Format: string(utils.TEXT),
},
{
Name: "instance_guid",
Format: string(utils.TEXT),
},
{
Name: "plan",
Format: string(utils.TEXT),
},
{
Name: "label",
Format: string(utils.TEXT),
},
{
Name: "type",
Format: string(utils.TEXT),
},
}
if _, ok := credentialsMap["tags"]; ok {
metadata = append(metadata, utils.SecretMetadataProperty{Name: "tags", Format: string(utils.JSON)})
}
return metadata, nil
}
func (r *ServiceBindingReconciler) rotateCredentials(ctx context.Context, binding *servicesv1.ServiceBinding, btpAccessCredentialsSecret string) error {
suffix := "-" + utils.RandStringRunes(6)
log := utils.GetLogger(ctx)
if binding.Annotations != nil {
if _, ok := binding.Annotations[common.ForceRotateAnnotation]; ok {
log.Info("Credentials rotation - deleting force rotate annotation")
delete(binding.Annotations, common.ForceRotateAnnotation)
if err := r.Client.Update(ctx, binding); err != nil {
log.Info("Credentials rotation - failed to delete force rotate annotation")
return err
}
}
}
credInProgressCondition := meta.FindStatusCondition(binding.GetConditions(), common.ConditionCredRotationInProgress)
if credInProgressCondition.Reason == common.CredRotating {
if len(binding.Status.BindingID) > 0 && binding.Status.Ready == metav1.ConditionTrue {
log.Info("Credentials rotation - finished successfully")
now := metav1.NewTime(time.Now())
binding.Status.LastCredentialsRotationTime = &now
return r.stopRotation(ctx, binding)
} else if utils.IsFailed(binding) {
log.Info("Credentials rotation - binding failed stopping rotation")
return r.stopRotation(ctx, binding)
}
log.Info("Credentials rotation - waiting to finish")
return nil
}
if len(binding.Status.BindingID) == 0 {
log.Info("Credentials rotation - no binding id found nothing to do")
return r.stopRotation(ctx, binding)
}
bindings := &servicesv1.ServiceBindingList{}
err := r.Client.List(ctx, bindings, client.MatchingLabels{common.StaleBindingIDLabel: binding.Status.BindingID}, client.InNamespace(binding.Namespace))
if err != nil {
return err
}
if len(bindings.Items) == 0 {
smClient, err := r.GetSMClient(ctx, r.SecretResolver, binding.Namespace, btpAccessCredentialsSecret)
if err != nil {
return err
}
// rename current binding
log.Info("Credentials rotation - renaming binding to old in SM", "current", binding.Spec.ExternalName)
if _, errRenaming := smClient.RenameBinding(binding.Status.BindingID, binding.Spec.ExternalName+suffix, binding.Name+suffix); errRenaming != nil {
log.Error(errRenaming, "Credentials rotation - failed renaming binding to old in SM", "binding", binding.Spec.ExternalName)
utils.SetCredRotationInProgressConditions(common.CredPreparing, errRenaming.Error(), binding)
if errStatus := utils.UpdateStatus(ctx, r.Client, binding); errStatus != nil {
return errStatus
}
return errRenaming
}
log.Info("Credentials rotation - backing up old binding in K8S", "name", binding.Name+suffix)
if err := r.createOldBinding(ctx, suffix, binding); err != nil {
log.Error(err, "Credentials rotation - failed to back up old binding in K8S")
utils.SetCredRotationInProgressConditions(common.CredPreparing, err.Error(), binding)
if errStatus := utils.UpdateStatus(ctx, r.Client, binding); errStatus != nil {
return errStatus
}
return err
}
}
binding.Status.BindingID = ""
binding.Status.Ready = metav1.ConditionFalse
utils.SetInProgressConditions(ctx, smClientTypes.CREATE, "rotating binding credentials", binding)
utils.SetCredRotationInProgressConditions(common.CredRotating, "", binding)
return utils.UpdateStatus(ctx, r.Client, binding)
}
func (r *ServiceBindingReconciler) stopRotation(ctx context.Context, binding *servicesv1.ServiceBinding) error {
conditions := binding.GetConditions()
meta.RemoveStatusCondition(&conditions, common.ConditionCredRotationInProgress)
binding.Status.Conditions = conditions
return utils.UpdateStatus(ctx, r.Client, binding)
}
func (r *ServiceBindingReconciler) createOldBinding(ctx context.Context, suffix string, binding *servicesv1.ServiceBinding) error {
oldBinding := newBindingObject(binding.Name+suffix, binding.Namespace)
err := controllerutil.SetControllerReference(binding, oldBinding, r.Scheme)
if err != nil {
return err
}
oldBinding.Labels = map[string]string{
common.StaleBindingIDLabel: binding.Status.BindingID,
common.StaleBindingRotationOfLabel: binding.Name,
}
spec := binding.Spec.DeepCopy()
spec.CredRotationPolicy.Enabled = false
spec.SecretName = spec.SecretName + suffix
spec.ExternalName = spec.ExternalName + suffix
oldBinding.Spec = *spec
return r.Client.Create(ctx, oldBinding)
}
func (r *ServiceBindingReconciler) handleStaleServiceBinding(ctx context.Context, serviceBinding *servicesv1.ServiceBinding) (ctrl.Result, error) {
log := utils.GetLogger(ctx)
originalBindingName, ok := serviceBinding.Labels[common.StaleBindingRotationOfLabel]
if !ok {
//if the user removed the "rotationOf" label the stale binding should be deleted otherwise it will remain forever
log.Info("missing rotationOf label, unable to fetch original binding, deleting stale")
return ctrl.Result{}, r.Client.Delete(ctx, serviceBinding)
}
origBinding := &servicesv1.ServiceBinding{}
if err := r.Client.Get(ctx, types.NamespacedName{Namespace: serviceBinding.Namespace, Name: originalBindingName}, origBinding); err != nil {
if apierrors.IsNotFound(err) {
log.Info("original binding not found, deleting stale binding")
return ctrl.Result{}, r.Client.Delete(ctx, serviceBinding)
}
return ctrl.Result{}, err