-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure with INCLUDE TYPE #76
Comments
Interesting question. My team has been using While sub-structures, as recommended in the help, are generally easy to use, they can become a problem when defining table types. Should we give this some more thorough discussion? |
Suggest to close this question. After some initial discussion, there was no activity anymore. |
For what it's worth, I agree |
I am writing a numerical tower where the structure for complex numbers is
with the structure for "simple" numbers (integer, rational, real) being used twice.
The components of the imaginary part (a real sub-structure) can only be accessed as imag_part-int. The components of the real part can be accessed either directly as int or indirectly as real_part-int. The help want us to prefer real sub-structures because of the following issues:
The help warns such type definitions should not be leaked outside their scope to avoid incompatible structure change. I think I get it, but we have had this for years with the enhancement category of dictionary structures. I get a warning from the syntax check, but I still have to enhance existing structures because it is so useful to do. I find the ability to access both the structure and its components individually very useful. This means I would advocate for I see the points with metadata storage and static boxes as performance enhancements in some specific contexts. From my current perspective, they are not relevant. I wanted to express my dissent on this topic of the online help that is not covered in the main text. It is OK with me if it is only expressed here and the question is closed. best regards, JNN |
Consensus here appears to be to not change the style guide - use INCLUDE TYPE as you will (or won't). |
is there a discussion about structure definition?
my 2 cents: the documentation says INCLUDE TYPE should not be used:
https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/index.htm?file=abapinclude_type.htm
I do not agree. as I like INCLUDE TYPE struct_type AS Name as it helps to avoid a lot of MOVE-CORRESPONDING later.
The text was updated successfully, but these errors were encountered: