[FIX] moduleBundler: Apply defaultFileTypes #580
Merged
+153
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
force-pushed
the
defaultFileTypes
branch
from
40dfdd3
to
759a4ae
Compare
Use default if not provided in bundle definition. In the past neither a default, nor the bundle definition configuration was used, since the parameter was mistakenly expected on the bundle options. Also align the defaults for library- and component-bundles with Maven.
RandomByte
force-pushed
the
defaultFileTypes
branch
from
759a4ae
to
b86029f
Compare
RandomByte
changed the title
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Feb 26, 2021
|
Paging @codeworrior: Should EDIT: Based on this comment I understand that flex changes must be part of the
|
RandomByte
reviewed
Mar 3, 2021
| @@ -85,12 +85,25 @@ module.exports = function({ | |||
| allNamespaces.forEach((ns) => { | |||
| if (ns !== namespace && ns.startsWith(`${namespace}/`)) { | |||
| filters.push(`!${ns}/`); | |||
| // Explicitly exclude manifest.json files of subcomponents since the general exclude above this | |||
| // comment only applies to the configured default file types, which do not include ".json" | |||
| filters.push(`!${ns}/**/manifest.json`); | |||
There was a problem hiding this comment.
Not sure whether this is our intention. But I guess it's a good solution for the time being.
The exclude-regex generated by ResourceFilterList always applies the default file types and therefore won't exclude manifest.json:
// !library/h/components/subcomponent3/ --> exclude:
/^library\/h\/components\/subcomponent3\/(?:[^/]+\/)*[^/]*(?:\.js|\.control\.xml|\.fragment\.html|\.fragment\.json|\.fragment\.xml|\.view\.html|\.view\.json|\.view\.xml|\.properties)$/…tandalone-app-bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default if not provided in bundle definition.
In the past neither a default, nor the bundle definition configuration
was used, since the parameter was mistakenly expected on the bundle
options.
Also align the defaults for library- and component-bundles with Maven.
New moduleBundler defaults:
.js.control.xml.fragment.html.fragment.json.fragment.xml.view.html.view.json.view.xmComponent-bundles (Component-preload.js and sap-ui-custom.js) additionally include:
.properties${namespace}/**/manifest.json${namespace}/changes/flexibility-bundle.json${namespace}/changes/changes-bundle.json