Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] generateResourcesJson: Add raw-module info for debug bundles #736

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Apr 21, 2022

The raw-module info within .library is only maintained using the
non-debug name. Therefore, the analysis must use that name when running
with debug bundles.

Furthermore the handling of the "module" property for debug resources
has been changed to only take place within the ResourceCollector.

JIRA: CPOUI5FOUNDATION-480

The raw-module info within .library is only maintained using the
non-debug name. Therefore, the analysis must use that name when running
with debug bundles.

Furthermore the handling of the "module" property for debug resources
has been changed to only take place within the ResourceCollector.

JIRA: CPOUI5FOUNDATION-480
@coveralls
Copy link

coveralls commented Apr 21, 2022

Coverage Status

Coverage increased (+0.05%) to 94.883% when pulling 32c95fc on next-fix-debug-bundle-raw-module-info into 4493b13 on next.

Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandomByte
Copy link
Member

LGTM

1 similar comment
@flovogt
Copy link
Member

flovogt commented Apr 22, 2022

LGTM

Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 merged commit 3b918e8 into next Apr 25, 2022
@matz3 matz3 deleted the next-fix-debug-bundle-raw-module-info branch April 25, 2022 14:11
This was referenced May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants