[FEATURE] builder: Improve support for ES6+ syntax #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
changed the title
matz3
changed the title
flovogt
force-pushed
the
next-JSModuleAnalyzer-enhance-es6-syntax-tests
branch
3 times, most recently
from
112207c
to
cb7e451
Compare
flovogt
changed the title
flovogt
force-pushed
the
next-JSModuleAnalyzer-enhance-es6-syntax-tests
branch
from
177df97
to
6f2793b
Compare
flovogt
changed the title
matz3
force-pushed
the
next-JSModuleAnalyzer-enhance-es6-syntax-tests
branch
from
efa5eab
to
51cf739
Compare
codeworrior
changed the title
flovogt
force-pushed
the
next-JSModuleAnalyzer-enhance-es6-syntax-tests
branch
from
098331c
to
49b0f73
Compare
matz3
changed the title
flovogt
force-pushed
the
next-JSModuleAnalyzer-enhance-es6-syntax-tests
branch
from
49b0f73
to
7308a04
Compare
JIRA: CPOUI5FOUNDATION-374
flovogt
force-pushed
the
next-JSModuleAnalyzer-enhance-es6-syntax-tests
branch
from
7308a04
to
f3df91a
Compare
flovogt
changed the title
… XMLComposite, SmartTemplate and FioriElements
flovogt
force-pushed
the
next-JSModuleAnalyzer-enhance-es6-syntax-tests
branch
from
2a3884a
to
e4783b1
Compare
matz3
commented
Aug 25, 2022
codeworrior
reviewed
Aug 29, 2022
| } | ||
| }); | ||
| } | ||
| if (defineCall.factory.async) { |
There was a problem hiding this comment.
This message is IMO misleading. The ui5loader can handle async callbacks. The returned promise is just used as export value and delivered to anyone importing the module.
Here, the smart templates (FE v2) cannot handle such a promise. That's the reason why we should log a message.
There was a problem hiding this comment.
Thanks Frank. Correct. So what should we log in case of the XMLComposite here the artefact can be placed in the view declaratively. The sap.ui.core.mvc.XMLView does not support returning a promise, correct? But do we know who consumes the XMLComposite. A typed view might import the asynchronously defined XMLComposite and can handle the asynchronism.
There was a problem hiding this comment.
Let's handle this in a follow-up PR, so that we can merge the current changes.
matz3
changed the title
matz3
changed the title
To be added in a follow-up PR
RandomByte
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-374