[BREAKING] Transform module to ESM #790

d3xter666 · 2022-09-20T11:14:49Z

JIRA: CPOUI5FOUNDATION-525

lib/tasks/buildThemes.js

lib/lbt/resources/LibraryFileAnalyzer.js

lib/processors/jsdoc/jsdocGenerator.js

- remove "use strict" - add "type": "module" to package.json - replace main with exports in package.json

- generateThemeDesignerResources - builder - themeBuilder

RandomByte · 2022-10-20T14:52:54Z

Rebased onto latest next

lib/lbt/analyzer/XMLTemplateAnalyzer.js

test/lib/lbt/analyzer/JSModuleAnalyzer.js

test/lib/lbt/analyzer/XMLCompositeAnalyzer.js

test/lib/lbt/bundle/Builder.js

test/lib/lbt/resources/Resource.js

test/lib/tasks/buildThemes.js

test/lib/tasks/bundlers/generateStandaloneAppBundle.integration.js

test/lib/tasks/generateVersionInfo.js

test/lib/lbt/bundle/Builder.js

test/lib/lbt/analyzer/XMLCompositeAnalyzer.js

test/lib/lbt/resources/Resource.js

test/lib/tasks/buildThemes.js

test/lib/tasks/bundlers/generateStandaloneAppBundle.integration.js

test/lib/tasks/generateVersionInfo.js

test/lib/lbt/resources/Resource.js

test/lib/lbt/utils/escapePropertiesFile.js

coveralls · 2022-10-24T13:35:24Z

Coverage decreased (-0.2%) to 94.267% when pulling 637da99 on esm into 5fef03d on next.

outdated

lib/processors/bundlers/moduleBundler.js

flovogt force-pushed the esm branch from 783f788 to e3f7804 Compare September 23, 2022 13:55

matz3 previously requested changes Sep 28, 2022

View reviewed changes

lib/tasks/buildThemes.js Outdated Show resolved Hide resolved

matz3 reviewed Sep 28, 2022

View reviewed changes

lib/lbt/resources/LibraryFileAnalyzer.js Outdated Show resolved Hide resolved

matz3 force-pushed the esm branch from 581d58d to 5dfee3c Compare October 4, 2022 11:26

matz3 changed the title ~~[INTERNAL][WIP] Migrate to ESM modules~~ [BREAKING] Transform module to ESM Oct 5, 2022

matz3 reviewed Oct 7, 2022

View reviewed changes

lib/processors/jsdoc/jsdocGenerator.js Outdated Show resolved Hide resolved

RandomByte force-pushed the esm branch from 8525c7c to 48f8dc3 Compare October 10, 2022 09:25

d3xter666 requested review from matz3 and flovogt October 10, 2022 11:58

d3xter666 and others added 21 commits October 20, 2022 16:52

Adapt source files

587b4c8

Adapt tests

04ed9f2

Adapt project depenencies

7f03ca3

Adjust files:

8356fc7

- remove "use strict" - add "type": "module" to package.json - replace main with exports in package.json

Remove "use strict"

14eb7c8

Fix tests

c2334fa

Fix tests

94c086a

esmock esmock for Resource.js

cb57fca

Fix esmock-s

b2b2b1b

fix bootstrapHtmlTransformer/libraryLessGenerator/manifestCreator

490f434

minifier/resourceListCreator

f276482

fix typo but still stub does not work

952f074

buildThemes

b889551

ESMock-s

ec27002

- generateThemeDesignerResources - builder - themeBuilder

Migrate tests to AVA 4

119196b

Fix imports

d6a4b21

Fix imports

feb8472

fix lib/lbt/analyzer

0f5e882

fix lib/lbt/calls

b7ad81e

fix lib/lbt/graph

8b62353

fix resources part1

fc5fcf6

d3xter666 and others added 5 commits October 20, 2022 16:52

JSDoc: Fix local type definitons

270eed2

JSDoc: Modularize links

91a4da9

Fix eslint errors

6808fd4

Remove workrounds for JSDoc

ddfe7cc

remove eslint-disable of ava/no-unknown-modifiers

a1d609a

RandomByte force-pushed the esm branch from e067ff3 to a1d609a Compare October 20, 2022 14:52

add test to check number of exports

48b09ac

flovogt requested changes Oct 24, 2022

View reviewed changes

flovogt added 2 commits October 24, 2022 08:49

code smells

62f7616

smaller refactorings

bd6673d

flovogt previously approved these changes Oct 24, 2022

View reviewed changes

readd todo comments

25aae33

flovogt dismissed their stale review via 25aae33 October 24, 2022 09:04

RandomByte previously approved these changes Oct 24, 2022

View reviewed changes

flovogt dismissed RandomByte’s stale review via a3e1db3 October 24, 2022 12:20

flovogt force-pushed the esm branch from a3e1db3 to 54320df Compare October 24, 2022 12:21

point to project esm branch

cb95a26

flovogt force-pushed the esm branch from 54320df to cb95a26 Compare October 24, 2022 12:24

[INTERNAL] Bump @ui5/logger and @ui5/fs

f140356

flovogt force-pushed the esm branch from 9ec70fe to f140356 Compare October 24, 2022 13:24

Update @ui5/project dependency

54a4c93

Adjust subpath exports

637da99

flovogt approved these changes Oct 24, 2022

View reviewed changes

RandomByte approved these changes Oct 24, 2022

View reviewed changes

flovogt merged commit a439aa9 into next Oct 24, 2022

flovogt deleted the esm branch October 24, 2022 13:55

matz3 reviewed Oct 25, 2022

View reviewed changes

lib/processors/bundlers/moduleBundler.js Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BREAKING] Transform module to ESM #790

[BREAKING] Transform module to ESM #790

d3xter666 commented Sep 20, 2022

RandomByte commented Oct 20, 2022

coveralls commented Oct 24, 2022 •

edited

[BREAKING] Transform module to ESM #790

[BREAKING] Transform module to ESM #790

Conversation

d3xter666 commented Sep 20, 2022

RandomByte commented Oct 20, 2022

coveralls commented Oct 24, 2022 • edited

coveralls commented Oct 24, 2022 •

edited