Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] package.json: Downgrade es5-ext dependency #798

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Oct 12, 2022

Downgrade es5-ext dependency as latest versions cause alerts in multiple Antivirus solutions (medikoo/es5-ext#186).

Also downgrade es6-set, since the latest version requires an affected version of es5-ext.

In general, none of these dependencies are required for ui5-builder. We install them transitively through escope. escope has an unreleased (and old) PR for dropping them: estools/escope#124

Downgrade es5-ext dependency as latest versions cause alerts in multiple
Antivirus solutions (medikoo/es5-ext#186).

Also downgrade es6-set, since the latest version requires an affected
version of es5-ext.

In general, none of these dependencies are required for ui5-builder. We
install them transitively through escope. escope has an unreleased (and
old) PR for dropping them: estools/escope#124
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.755% when pulling ad3fedc on downgrade-es5-ext-dep into 3a1d1ed on master.

Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandomByte RandomByte merged commit 0e18008 into master Oct 12, 2022
@RandomByte RandomByte deleted the downgrade-es5-ext-dep branch October 12, 2022 13:09
RandomByte added a commit that referenced this pull request Oct 12, 2022
RandomByte added a commit that referenced this pull request Oct 12, 2022
RandomByte added a commit that referenced this pull request Oct 12, 2022
RandomByte added a commit that referenced this pull request Oct 12, 2022
RandomByte added a commit that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants