Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Removal of manifestBundler and generateManifestBundle #838

Merged
merged 3 commits into from
Nov 11, 2022
Merged

[BREAKING] Removal of manifestBundler and generateManifestBundle #838

merged 3 commits into from
Nov 11, 2022

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Nov 9, 2022 •
edited

JIRA: CPOUI5FOUNDATION-529

@flovogt flovogt changed the title [BREAKING] Removement of manifestBundler and generateManifestBundle [BREAKING] Removal of manifestBundler and generateManifestBundle Nov 9, 2022
@coveralls
Copy link

coveralls commented Nov 9, 2022 •
edited

Coverage Status

Coverage decreased (-0.01%) to 94.706% when pulling 8400544 on remove-manifest-bundler into 2d63f35 on main.

matz3
matz3 requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task also should be removed from taskRepository and handled like the other removed tasks (e.g. "createDebugFiles")

@flovogt flovogt mentioned this pull request Nov 11, 2022
Merged
@flovogt
Copy link
Member Author

flovogt commented Nov 11, 2022

The task also should be removed from taskRepository and handled like the other removed tasks (e.g. "createDebugFiles")

Done

@flovogt flovogt requested a review from matz3 November 11, 2022 07:35
matz3
matz3 previously approved these changes Nov 11, 2022
View reviewed changes
@matz3 matz3 dismissed their stale review November 11, 2022 07:49

let me rethink..

@flovogt flovogt mentioned this pull request Nov 11, 2022
Closed
17 tasks
@flovogt flovogt merged commit 07a5be2 into main Nov 11, 2022
@flovogt flovogt deleted the remove-manifest-bundler branch November 11, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

@RandomByte RandomByte Awaiting requested review from RandomByte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flovogt @coveralls @matz3