Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] JSDoc: Fail build when jsdoc command failed #845

Merged
merged 2 commits into from
Nov 18, 2022
Merged

[BREAKING] JSDoc: Fail build when jsdoc command failed #845

merged 2 commits into from
Nov 18, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Nov 17, 2022 •
edited

BREAKING CHANGE:
The jsdocGenerator processor and the corresponding generateJsdoc task will now throw an error when JSDoc reports an error (exit code != 0). This will also fail the build when running ui5 build jsdoc.

JIRA: CPOUI5FOUNDATION-530

@coveralls
Copy link

coveralls commented Nov 17, 2022 •
edited

Coverage Status

Coverage decreased (-0.003%) to 94.703% when pulling 2bf2ad9 on jsdoc-handle-exit-code into 62a1425 on main.

@matz3 matz3 mentioned this pull request Nov 18, 2022
Merged
@matz3 matz3 merged commit c2916b4 into main Nov 18, 2022
@matz3 matz3 deleted the jsdoc-handle-exit-code branch November 18, 2022 14:06
@flovogt flovogt mentioned this pull request Dec 1, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@codeworrior codeworrior Awaiting requested review from codeworrior

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matz3 @coveralls @RandomByte