[FEATURE] Introduce Readers "Filter" and "Transformer" #331
+528
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
add-reader-filter
branch
2 times, most recently
from
2022096
to
b7a6080
Compare
2 tasks
RandomByte
force-pushed
the
add-reader-filter
branch
from
b7a6080
to
93d5d24
Compare
RandomByte
force-pushed
the
add-reader-filter
branch
from
93d5d24
to
a7403e4
Compare
RandomByte
force-pushed
the
add-reader-filter
branch
from
a7403e4
to
b3993d8
Compare
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Dec 2, 2021
KlattG
suggested changes
Dec 6, 2021
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
KlattG
previously approved these changes
Dec 6, 2021
matz3
requested changes
Dec 6, 2021
lib/AbstractReader.js
Outdated
| @@ -70,6 +70,14 @@ class AbstractReader { | |||
| }); | |||
| } | |||
|
|
|||
| filter(callback) { | |||
| const ReaderFilter = require("./ReaderFilter"); | |||
There was a problem hiding this comment.
Note: Cyclic dependency
This shouldn't cause any issues but we might also just use the "ReaderFilter" directly within ui5-builder.
This should make resource clone operations cheaper since the content doesn't need to be read and cloned immediately
|
@KlattG I think there's no further review necessary from your side. Thanks |
No major benefits since streams need to be drained into a buffer anyways. This reverts commit ecd7bd6.
… of instance We don't need more information anyways
matz3
reviewed
Dec 23, 2021
matz3
reviewed
Dec 23, 2021
|
@KlattG could you please have a look at the JSDoc in the following three files? Thanks!
|
KlattG
reviewed
Jan 10, 2022
lib/readers/Filter.js
Outdated
| * @public | ||
| * @callback module:@ui5/fs.readers.Filter~callback | ||
| * @param {module:@ui5/fs.Resource} resource Resource to test | ||
| * @returns {boolean} Return <code>true</code> to keep the resource, or <code>false</code> to disregard it |
There was a problem hiding this comment.
Suggested change
| * @returns {boolean} Return <code>true</code> to keep the resource, or <code>false</code> to disregard it | |
| * @returns {boolean} Whether to keep the resource |
lib/AbstractReader.js
Outdated
| * @public | ||
| * @param {module:@ui5/fs.readers.Filter~callback} callback | ||
| * Filter function. Will be called for every resource passed through this reader. | ||
| * @returns {module:@ui5/fs.reader.Transformer} T |
lib/AbstractReader.js
Outdated
| * @public | ||
| * @param {module:@ui5/fs.readers.Transformer~callback} callback | ||
| * Callback to check and eventually transform any resource passed through the reader | ||
| * @returns {module:@ui5/fs.reader.Transformer} T |
matz3
approved these changes
Jan 13, 2022
RandomByte
changed the title
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs