[FIX] ui5Framework.Installer: Ensure target directory does not exist before rename #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before rename Renaming a directory might fail with an EPERM error on Windows if the target already exists. Therefore we stop creating the target directory before the rename (this was probably the main problem) and also ensure that it does not exist for whatever other reasons. Related: #389 Resolves: SAP/ui5-tooling#487
|
@matz3 kindly retest in your Windows reproduction setup |
|
Validated by manually replacing the file within node_modules after a failing installation. |
matz3
requested changes
Jan 28, 2021
Comment on lines
+82
to
+85
| // Check whether target dir already exists and remove it. | ||
| // A target directory already existing but missing a package.json should | ||
| // never happen. However, we want to be *really* sure that there is no target | ||
| // directory so that the rename operation won't have any no trouble. |
There was a problem hiding this comment.
Just as a note: This is especially important to fix the broken setup with CLI v2.9.0.
Co-authored-by: Matthias Oßwald <1410947+matz3@users.noreply.github.com>
matz3
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming a directory might fail with an EPERM error on Windows if the
target already exists. Therefore we stop creating the target directory
before the rename (this was probably the main problem) and also ensure
that it does not exist for whatever other reasons.
Related: #389
Resolves: SAP/ui5-tooling#487