Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectPage: display header image on the left of header title #97

Closed
SunnyWind opened this issue Aug 16, 2019 · 4 comments
Closed

ObjectPage: display header image on the left of header title #97

SunnyWind opened this issue Aug 16, 2019 · 4 comments
Labels
feature-request New feature or request
Milestone
v0.6.0

Comments

@SunnyWind
Copy link

SunnyWind commented Aug 16, 2019 •
edited
Loading

In below UI5 Object Page examples, the header image can be positioned on the left of the header title.
https://sapui5.hana.ondemand.com/#/entity/sap.uxap.ObjectPageLayout/sample/sap.uxap.sample.ObjectPageOnJSON
https://sapui5.hana.ondemand.com/#/entity/sap.uxap.ObjectPageLayout/sample/sap.uxap.sample.ObjectPageHeaderContentPriorities

However, as far as I knew, ObjectPage component in UI5-webcomponents-react doesn't support this feature. (The header image is always displayed beneath the title.) Could it be added?

Current:
image

Expected:
image
@MarcusNotheis MarcusNotheis mentioned this issue Aug 16, 2019
Closed
@MarcusNotheis
Copy link
Contributor

Hi @SunnyWind,

thanks for submitting this feature request. As it was already requested by #92, I'll mark this as duplicate. You can track the status by following issue #99.

Best regards,
Marcus

@MarcusNotheis MarcusNotheis added the duplicate This issue or pull request already exists label Aug 16, 2019
@SunnyWind
Copy link
Author

OK. Thanks.

@MarcusNotheis
Copy link
Contributor

Hi @SunnyWind,

sorry, I misunderstood your issue. We'll add a property showTitleInHeaderContent like it is in UI5 which will enable the requested feature.

Best regards,
Marcus

@MarcusNotheis MarcusNotheis added feature-request New feature or request and removed duplicate This issue or pull request already exists labels Oct 9, 2019
@MarcusNotheis MarcusNotheis modified the milestones: v0.7.0, v0.6.0 Oct 9, 2019
@MarcusNotheis
Copy link
Contributor

Fixed by #179, released in v0.6.0-rc.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
2 participants
@SunnyWind @MarcusNotheis