fix(ui5-dialog): Fixed RTL mode (#3070)

Fixes: #3013
SAP · Apr 1, 2021 · 0aac048 · 0aac048
1 parent 00d0be4
commit 0aac048
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/packages/main/src/Popup.hbs b/packages/main/src/Popup.hbs
@@ -5,7 +5,7 @@
 	aria-modal="{{_ariaModal}}"
 	aria-label="{{_ariaLabel}}"
 	aria-labelledby="{{_ariaLabelledBy}}"
-	dir="{{dir}}"
+	dir="{{effectiveDir}}"
 	tabindex="-1"
 	@keydown={{_onkeydown}}
 	@focusout={{_onfocusout}}

diff --git a/packages/main/src/Popup.js b/packages/main/src/Popup.js
@@ -1,6 +1,5 @@
 import { renderFinished } from "@ui5/webcomponents-base/dist/Render.js";
 import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
-import { getRTL } from "@ui5/webcomponents-base/dist/config/RTL.js";
 import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js";
 import { getFirstFocusableElement, getLastFocusableElement } from "@ui5/webcomponents-base/dist/util/FocusableElements.js";
 import createStyleInHead from "@ui5/webcomponents-base/dist/util/createStyleInHead.js";
@@ -514,10 +513,6 @@ class Popup extends UI5Element {
 		return this.shadowRoot.querySelector(".ui5-popup-root");
 	}
 
-	get dir() {
-		return getRTL() ? "rtl" : "ltr";
-	}
-
 	get styles() {
 		return {
 			root: {},