feat(ui5-tools): libraries can now control chromedriver version (#1684)

SAP · May 27, 2020 · 2da6a34 · 2da6a34
1 parent 8bc6959
commit 2da6a34
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 5 deletions.
diff --git a/packages/base/package.json b/packages/base/package.json
@@ -31,6 +31,7 @@
   },
   "devDependencies": {
     "@ui5/webcomponents-tools": "1.0.0-rc.7",
+    "chromedriver": "latest",
     "array-uniq": "^2.0.0",
     "copy-and-watch": "^0.1.4",
     "eslint": "^5.13.0",

diff --git a/packages/fiori/package.json b/packages/fiori/package.json
@@ -31,6 +31,7 @@
     "@ui5/webcomponents-theme-base": "1.0.0-rc.7"
   },
   "devDependencies": {
-    "@ui5/webcomponents-tools": "1.0.0-rc.7"
+    "@ui5/webcomponents-tools": "1.0.0-rc.7",
+    "chromedriver": "latest"
   }
 }
diff --git a/packages/icons/package.json b/packages/icons/package.json
@@ -24,6 +24,7 @@
     "@ui5/webcomponents-base": "0.20.0"
   },
   "devDependencies": {
-    "@ui5/webcomponents-tools": "1.0.0-rc.7"
+    "@ui5/webcomponents-tools": "1.0.0-rc.7",
+    "chromedriver": "latest"
   }
 }
diff --git a/packages/localization/package.json b/packages/localization/package.json
@@ -25,6 +25,7 @@
     "@buxlabs/amd-to-es6": "^0.15.0",
     "@openui5/sap.ui.core": "1.76.0",
     "@ui5/webcomponents-tools": "1.0.0-rc.7",
+    "chromedriver": "latest",
     "copy-and-watch": "^0.1.4",
     "escodegen": "^1.11.0",
     "esprima": "^4.0.1",

diff --git a/packages/main/package.json b/packages/main/package.json
@@ -31,6 +31,7 @@
     "@ui5/webcomponents-theme-base": "1.0.0-rc.7"
   },
   "devDependencies": {
-    "@ui5/webcomponents-tools": "1.0.0-rc.7"
+    "@ui5/webcomponents-tools": "1.0.0-rc.7",
+    "chromedriver": "latest"
   }
 }
diff --git a/packages/theme-base/package.json b/packages/theme-base/package.json
@@ -28,6 +28,7 @@
   },
   "devDependencies": {
     "@ui5/webcomponents-tools": "1.0.0-rc.7",
+    "chromedriver": "latest",
     "chokidar-cli": "^2.0.0",
     "copy-and-watch": "^0.1.4",
     "cssnano": "^4.1.10",

diff --git a/packages/tools/lib/init-package/index.js b/packages/tools/lib/init-package/index.js
@@ -100,6 +100,9 @@ const updatePackageFile = () => {
 		"prepublishOnly": "npm run build"
 	};
 
+	packageContent.devDependencies = packageContent.devDependencies || {};
+	packageContent.devDependencies["chromedriver"] = "latest";
+
 	fs.writeFileSync("package.json", beautify(packageContent, null, 2, 100));
 };
 

diff --git a/packages/tools/package.json b/packages/tools/package.json
@@ -35,7 +35,6 @@
     "@webcomponents/webcomponentsjs": "^2.4.0",
     "chai": "^4.2.0",
     "chokidar-cli": "^2.0.0",
-    "chromedriver": "^83.0.0",
     "clean-css": "^4.2.1",
     "command-line-args": "^5.1.1",
     "concurrently": "^5.0.0",
@@ -74,6 +73,9 @@
     "serve": "^10.1.1",
     "wdio-chromedriver-service": "^6.0.2"
   },
+  "peerDependencies": {
+    "chromedriver": "*"
+  },
   "resolutions": {
     "rollup-plugin-livereload/livereload/chokidar": "^3.x"
   }

diff --git a/yarn.lock b/yarn.lock
@@ -1996,7 +1996,7 @@ chrome-launcher@^0.13.1:
     mkdirp "^0.5.3"
     rimraf "^3.0.2"
 
-chromedriver@^83.0.0:
+chromedriver@latest:
   version "83.0.0"
   resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-83.0.0.tgz#75d7d838e58014658c3990089464166fef951926"
   integrity sha512-AePp9ykma+z4aKPRqlbzvVlc22VsQ6+rgF+0aL3B5onHOncK18dWSkLrSSJMczP/mXILN9ohGsvpuTwoRSj6OQ==