Skip to content

Commit

Permalink
fix(icons): overflow icon is now centered (#1777)
Browse files Browse the repository at this point in the history
  • Loading branch information
vladitasev committed Jun 12, 2020
1 parent 37bf177 commit 36d0eca
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
4 changes: 2 additions & 2 deletions packages/icons/src/icon-collections/SAP-icons.json
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@
"outbox": "M382 111q11 12 0 23-12 11-23 0l-87-87v226q0 16-16 16t-16-16V49l-85 85q-5 5-11 5t-11-5q-12-11 0-23L235 10q9-10 22-10t23 10zm98 209h-96q0 32-31 32H160q-32 0-32-32H32q-14 0-23 9.5T0 352v128q0 14 9 23t23 9h448q13 0 22.5-9t9.5-23V352q0-13-9.5-22.5T480 320zm0 160H32V352h71q17 32 57 32h193q39 0 56-32h71v128zm-144-64H176q-7 0-11.5 5t-4.5 11q0 16 16 16h160q6 0 11-4.5t5-11.5q0-6-5-11t-11-5z",
"outdent": "M325 254q-7 7 0 10l53 60q11 12 0 23-12 10-23 0l-58-65q-9-9-9-22t9-23l61-65q11-11 22 0 13 13 0 22zM464 64q16 0 16 16t-16 16H48q-16 0-16-16t16-16h416zM48 192q-16 0-16-16t16-16h160q16 0 16 16t-16 16H48zm0 96q-16 0-16-16t16-16h160q16 0 16 16t-16 16H48zm0 96q-16 0-16-16t16-16h160q16 0 16 16t-16 16H48zm416 64q16 0 16 16t-16 16H48q-16 0-16-16t16-16h416z",
"outgoing-call": "M368 298q17 16 33 32l32 32q15 15 14.5 33T433 428q-6 5-11.5 10.5T411 450q-15 17-33.5 23.5T339 480h-8l-9-1q-36-4-68-18.5T192 426q-54-37-96-83.5T25 237q-10-20-16-40.5T1 154q-2-24 3.5-45.5T30 70q6-5 11.5-11t16-16.5T86 32q15 0 30 13l34 34 34 35q14 14 13 31t-15 31q-9 10-18 19l-19 19q49 72 121 121 19-18 37-37 17-15 33-15 18 0 32 15zm42 107q10-10 0-20-16-17-32-33l-32-32q-2-2-4.5-3.5T336 315q-6 0-10 6l-26 26-11 11-19 19-22-15q-38-28-70.5-60T118 232l-15-22 19-19 12-12q7-6 13-12.5t13-12.5q9-10 1-18-17-19-33.5-35.5T94 68q-6-4-8-4-6 0-10 6-2 2-4 3.5T68 77q-8 9-17 17-11 11-15.5 24.5T33 152q3 32 21 71 51 105 156 176 32 22 60 33.5t56 15.5h13q29 0 48-19 4-5 7.5-9t8.5-8zm93-317q9 10 9 23t-9 23l-92 86q-5 5-11 5t-11-5-5-11.5 5-11.5l75-69H273q-16 0-16-16t16-16h191l-75-68q-5-5-5-11.5T389 5t11-5 11 5z",
"overflow": "M448 352q26 0 45 19t19 45-19 45-45 19-45-19-19-45 19-45 45-19zm0 96q14 0 23-9t9-23-9-23-23-9-23 9-9 23 9 23 23 9zm-192-96q26 0 45 19t19 45-19 45-45 19-45-19-19-45 19-45 45-19zm0 96q14 0 23-9t9-23-9-23-23-9-23 9-9 23 9 23 23 9zM64 352q26 0 45 19t19 45-19 45-45 19-45-19-19-45 19-45 45-19zm0 96q14 0 23-9t9-23-9-23-23-9-23 9-9 23 9 23 23 9z",
"overflow": "M448 190q26 0 45 19t19 45-19 45-45 19-45-19-19-45 19-45 45-19zm0 96q14 0 23-9t9-23-9-23-23-9-23 9-9 23 9 23 23 9zm-192-96q26 0 45 19t19 45-19 45-45 19-45-19-19-45 19-45 45-19zm0 96q14 0 23-9t9-23-9-23-23-9-23 9-9 23 9 23 23 9zM64 190q26 0 45 19t19 45-19 45-45 19-45-19-19-45 19-45 45-19zm0 96q14 0 23-9t9-23-9-23-23-9-23 9-9 23 9 23 23 9z",
"overlay": "M256 0q53 0 100 20t81.5 55 54.5 81.5 20 99.5-20 100-54.5 82-81.5 55-100 20-99.5-20T75 438t-55-82T0 256t20-99.5T75 75t81.5-55T256 0zm0 481q46 0 87-17.5t71.5-48.5 48-71.5T480 256q0-46-17.5-86.5t-48-71-71.5-48T256 33t-87 17.5-71.5 48-48 71T32 256q0 47 17.5 87.5t48 71.5 71.5 48.5 87 17.5zm0-384q33 0 62.5 12.5t51 34 34 50.5 12.5 62-12.5 62.5-34 51.5-51 34.5T256 417t-62-12.5-51-34.5-34.5-51.5T96 256t12.5-62 34.5-50.5 51-34T256 97z",
"overview-chart": "M480 192q13 0 22.5 9.5T512 224v64q0 14-9.5 23t-22.5 9h-64q-14 0-23-9t-9-23v-32h-64v32q0 11-9 22l29 45q6-3 12-3h64q13 0 22.5 9.5T448 384v64q0 14-9.5 23t-22.5 9h-64q-14 0-23-9t-9-23v-64q0-9 7-20l-30-46q-6 2-9 2h-56l-48 75q3 5 5.5 10t2.5 11v64q0 14-9.5 23t-22.5 9H96q-14 0-23-9t-9-23v-64q0-13 9-22.5t23-9.5h64q4 0 10 2l44-68q6 2 10 2-14 0-23-9t-9-23v-32h-64v32q0 14-9.5 23T96 320H32q-14 0-23-9t-9-23v-64q0-13 9-22.5t23-9.5h64q13 0 22.5 9.5T128 224v16h64v-16q0-13 9-22.5t23-9.5q-3 0-9 2l-45-68q-6 2-10 2H96q-14 0-23-9t-9-23V32q0-13 9-22.5T96 0h64q13 0 22.5 9.5T192 32v64q0 11-9 22l50 74h55q3 0 7 2l31-48q-6-7-6-18V64q0-13 9-22.5t23-9.5h64q13 0 22.5 9.5T448 64v64q0 14-9.5 23t-22.5 9h-64q-8 0-14-3l-28 44q10 10 10 23v16h64v-16q0-13 9-22.5t23-9.5h64zm-128-64h64V64h-64v64zM160 32H96v64h64V32zM96 224H32v64h64v-64zm64 192H96v64h64v-64zm128-192h-64v64h64v-64zm64 224h64v-64h-64v64zm-43-247q-2-2-6-4 4 2 6 4zm-2 112q-2 2-4 3 2-1 4-3zm173-89h-64v64h64v-64z",
"paging": "M480 448q14 0 23 9t9 23q0 13-9 22.5t-23 9.5H32q-13 0-22.5-9.5T0 480q0-14 9.5-23t22.5-9h448zm0-224q14 0 23 9t9 23q0 13-9 22.5t-23 9.5H32q-13 0-22.5-9.5T0 256q0-14 9.5-23t22.5-9h448zM32 64q-13 0-22.5-9.5T0 32Q0 18 9.5 9T32 0h448q14 0 23 9t9 23q0 13-9 22.5T480 64H32z",
Expand Down Expand Up @@ -668,4 +668,4 @@
"defaultText": "Warning"
}
}
}
}
15 changes: 10 additions & 5 deletions packages/main/test/pages/Icon.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html>
<head>
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">
<meta charset="utf-8">

<title>Icon</title>
Expand Down Expand Up @@ -89,6 +89,11 @@
<br/>
<br/>

<ui5-button icon="overflow"></ui5-button>
<ui5-icon name="overflow" style="border:1px solid red;"></ui5-icon>
<br>
<br>

<script>
var icon = document.getElementById("interactive-icon"),
nonInteractiveIcon = document.getElementById("non-interactive-icon"),
Expand All @@ -104,7 +109,7 @@
});
</script>

<script type="module">
<script type="module">
(async () => {
var iconNames = await window["sap-ui-webcomponents-bundle"].getIconNames();
iconNames.forEach(iconName => {
Expand All @@ -113,17 +118,17 @@
document.body.appendChild(icon);
});
})();
</script>
</script>

<script nomodule>
<script nomodule>
window["sap-ui-webcomponents-bundle"].getIconNames().then(function(iconNames) {
iconNames.forEach(function(iconName) {
var icon = document.createElement("ui5-icon");
icon.name = iconName;
document.body.appendChild(icon);
});
});
</script>
</script>

</body>
</html>

0 comments on commit 36d0eca

Please sign in to comment.