fix(ui5-list): remove focus trap for empty list (#2411)

SAP · Nov 30, 2020 · 5f8e0e2 · 5f8e0e2
1 parent 37ee83f
commit 5f8e0e2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/main/src/List.hbs b/packages/main/src/List.hbs
@@ -14,7 +14,9 @@
 		</header>
 	{{/if}}
 
-	<div id="{{_id}}-before" tabindex="0" class="ui5-list-focusarea"></div>
+	{{#if hasData}}
+		<div id="{{_id}}-before" tabindex="0" class="ui5-list-focusarea"></div>
+	{{/if}}
 
 	<ul id="{{_id}}-listUl"
 		class="ui5-list-ul"
@@ -46,5 +48,7 @@
 		</div>
 	{{/if}}
 
-	<div id="{{_id}}-after" tabindex="0" class="ui5-list-focusarea"></div>
+	{{#if hasData}}
+		<div id="{{_id}}-after" tabindex="0" class="ui5-list-focusarea"></div>
+	{{/if}}
 </div>
diff --git a/packages/main/src/List.js b/packages/main/src/List.js
@@ -381,8 +381,12 @@ class List extends UI5Element {
 		return `${this._id}-header`;
 	}
 
+	get hasData() {
+		return this.items.length !== 0;
+	}
+
 	get showNoDataText() {
-		return this.items.length === 0 && this.noDataText;
+		return !this.hasData && this.noDataText;
 	}
 
 	get showBusy() {