fix: lists no longer show a dot on IE (#2011)

Despite having the right CSS style, for some reason it is not applied on IE until the component is repainted by the browser. Now, there are no dots already on the first load.
SAP · Jul 27, 2020 · 77cabba · 77cabba
1 parent ad30db8
commit 77cabba
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 8 deletions.
diff --git a/packages/fiori/src/NotificationListGroupItem.hbs b/packages/fiori/src/NotificationListGroupItem.hbs
@@ -7,6 +7,7 @@
 	tabindex="{{_tabIndex}}"
 	dir="{{effectiveDir}}"
 	aria-labelledby="{{ariaLabelledBy}}"
+	style="list-style-type: none;"
 >
 	<div class="ui5-nli-group-header">
 		<ui5-button

diff --git a/packages/fiori/src/NotificationListItem.hbs b/packages/fiori/src/NotificationListItem.hbs
@@ -9,6 +9,7 @@
 	tabindex="{{_tabIndex}}"
 	dir="{{effectiveDir}}"
 	aria-labelledby="{{ariaLabelledBy}}"
+	style="list-style-type: none;"
 >
 	<div class="ui5-nli-actions">
 		{{#if showOverflow}}

diff --git a/packages/main/src/GroupHeaderListItem.hbs b/packages/main/src/GroupHeaderListItem.hbs
@@ -5,6 +5,7 @@
 	@focusout="{{_onfocusout}}"
 	@keydown="{{_onkeydown}}"
 	role="option"
+	style="list-style-type: none;"
 >
 	<span class="ui5-hidden-text">{{groupHeaderText}}</span>
 

diff --git a/packages/main/src/List.hbs b/packages/main/src/List.hbs
@@ -26,7 +26,7 @@
 		<slot></slot>
 
 		{{#if showNoDataText}}
-			<li id="{{_id}}-nodata" class="ui5-list-nodata" tabindex="{{noDataTabIndex}}">
+			<li id="{{_id}}-nodata" class="ui5-list-nodata" tabindex="{{noDataTabIndex}}" style="list-style-type: none;">
 				<div id="{{_id}}-nodata-text" class="ui5-list-nodata-text">
 					{{noDataText}}
 				</div>

diff --git a/packages/main/src/ListItem.hbs b/packages/main/src/ListItem.hbs
@@ -15,6 +15,7 @@
 	role="{{_accInfo.role}}"
 	aria-expanded="{{_accInfo.ariaExpanded}}"
 	aria-level="{{_accInfo.ariaLevel}}"
+	style="list-style-type: none;"
 >
 		{{> listItemPreContent}}
 

diff --git a/packages/main/src/TabContainer.hbs b/packages/main/src/TabContainer.hbs
@@ -23,7 +23,7 @@
 						{{this.stripPresentation}}
 					{{/unless}}
 					{{#if this.isSeparator}}
-						<li id="{{this._id}}" role="separator" class="{{../classes.separator}}"></li>
+						<li id="{{this._id}}" role="separator" class="{{../classes.separator}}" style="list-style-type: none;"></li>
 					{{/if}}
 				{{/each}}
 			</ul>

diff --git a/packages/main/src/TabInStrip.hbs b/packages/main/src/TabInStrip.hbs
@@ -10,6 +10,7 @@
 	?disabled="{{this.effectiveDisabled}}"
 	aria-labelledby="{{this.ariaLabelledBy}}"
 	data-ui5-stable="{{this.stableDomRef}}"
+	style="list-style-type: none;"
 >
 
 	{{#if this.icon}}

diff --git a/packages/main/src/TabSeparator.hbs b/packages/main/src/TabSeparator.hbs
@@ -1 +1 @@
-<li id="{{_id}}" role="separator"></li>
+<li id="{{_id}}" role="separator" style="list-style-type: none;"></li>
diff --git a/packages/main/src/Timeline.hbs b/packages/main/src/Timeline.hbs
@@ -1,7 +1,7 @@
 <div class="ui5-timeline-root">
 	<ul class="ui5-timeline-list" role="listbox" aria-live="polite" aria-label="{{ariaLabel}}">
 		{{#each items}}
-			<li class="ui5-timeline-list-item">
+			<li class="ui5-timeline-list-item" style="list-style-type: none;">
 				<slot name="{{this._individualSlot}}"></slot>
 			</li>
 		{{/each}}

diff --git a/packages/main/src/WheelSlider.hbs b/packages/main/src/WheelSlider.hbs
@@ -1,4 +1,4 @@
-<div 
+<div
 	id="{{this._id}}"
 	?disabled= "{{disabled}}"
 	value = "{{value}}"
@@ -25,17 +25,17 @@
 			{{#if _expanded}}
 				<ul id="{{this._id}}--items-list">
 					{{#each _itemsToShow}}
-						<li class="ui5-wheelslider-item" data-item-index="{{@index}}">{{this}}</li>
+						<li class="ui5-wheelslider-item" data-item-index="{{@index}}" style="list-style-type: none;">{{this}}</li>
 					{{/each}}
 				</ul>
 			{{else}}
 				<ul id="{{this._id}}--items-list">
-					<li class="ui5-wheelslider-item">{{value}}</li>
+					<li class="ui5-wheelslider-item" style="list-style-type: none;">{{value}}</li>
 				</ul>
 			{{/if}}
 		</div>
 	</div>
 	<div class="ui5-wheelslider-footer-block">
 		<ui5-button class="ui5-wheelslider-arrow" icon="navigation-down-arrow" @click={{_onArrowDown}} tabindex="-1"></ui5-button>
 	</div>
-</div>
+</div>