Skip to content

Commit

Permalink
fix(ui5-icon): correct icon graphic vertical alignment in IE (#142)
Browse files Browse the repository at this point in the history
In RTL the icon is not vertical aligned in IE, that might be seen in before this change in the Icon sample in RTL, opened in IE.

* fix typo
  • Loading branch information
ilhan007 committed Mar 6, 2019
1 parent ef00170 commit 98be562
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions packages/main/src/themes/base/Icon.less
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,26 @@
color: @sapUiContentNonInteractiveIconColor;
}

:host(ui5-icon) span[data-sap-ui-wc-root] {
display: flex;
width: 100%;
height: 100%;
}

// required for browsers without native shadow dom
ui5-icon {
display: inline-block;
outline: none;
color: @sapUiContentNonInteractiveIconColor;
}

ui5-icon span[data-sap-ui-wc-root] {
display: flex;
width: 100%;
height: 100%;
// workaround for IE
// pressing on the span does not propagate active state to the web component
& span[data-sap-ui-wc-root] {
pointer-events: none;
}
pointer-events: none;
}

.sapWCIcon {
Expand Down

0 comments on commit 98be562

Please sign in to comment.