-
Notifications
You must be signed in to change notification settings - Fork 254
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(ui5-textarea): add "valueStateMessage" slot (#1419)
- add "valueStateMessage" slot - rename "valueStateMessage" CSS classes from "ui5-input-valuestatemessage-success" to "ui5-valuestatemessage--success", because they should not belong to the input only and ad two dashes to show modification (by the BEM notation) - there is code duplication at places with the code that handles the valueStateMessage in Input, but also differences related to the fact that the TextArea has no suggestions and has this "exceeding" (like Warning) state. FIXES: #1401
- Loading branch information
Showing
10 changed files
with
255 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{{#if displayValueStateMessage}} | ||
<ui5-popover | ||
skip-registry-update | ||
no-padding | ||
no-arrow | ||
_disable-initial-focus | ||
class="ui5-valuestatemessage-popover" | ||
style="{{styles.valueStateMsgPopover}}" | ||
placement-type="Bottom" | ||
horizontal-align="Left" | ||
> | ||
<div slot="header" class="ui5-valuestatemessage-root {{classes.valueStateMsg}}"> | ||
{{> valueStateMessage}} | ||
</div> | ||
</ui5-popover> | ||
{{/if}} | ||
|
||
{{#*inline "valueStateMessage"}} | ||
{{#if displayDefaultValueStateMessage}} | ||
{{valueStateText}} | ||
{{else}} | ||
{{#each valueStateMessageText}} | ||
{{this}} | ||
{{/each}} | ||
{{/if}} | ||
{{/inline}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.