Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-radiobutton): introduce wrap property #1006

Merged
merged 4 commits into from
Dec 9, 2019

Conversation

niyap
Copy link
Contributor

@niyap niyap commented Dec 3, 2019

FIXES: #981

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little imperfections I found when I tested it.

In Cozy : the text of the radio shifts a little upwards from the center (or compared to other radios that do not have wrap set)
In Compact: both the text and the circle (the entire component) shifts upwards.

You have to zoom a little bit to see the difference between wrap/no wrap radio.
It would be easier if you put two radios with short texts one next to other and set wrap to one of them.

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great now, it's good to have a sample of the new property within the playground (you can edit the RadioButton.sample.html), similar to the ui5-checkbox wrap sample.

@ilhan007 ilhan007 merged commit 99dd6c4 into SAP:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a wrap property to ui5-radiobutton
2 participants